Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial commit #1

Merged
merged 6 commits into from
Dec 1, 2016
Merged

Initial commit #1

merged 6 commits into from
Dec 1, 2016

Conversation

digitaldan
Copy link
Collaborator

Signed-off-by: Dan Cunningham dan@digitaldan.com

Signed-off-by: Dan Cunningham <dan@digitaldan.com>
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, can't wait to get that in place!

Besides my comments, two questions:

  1. Is it usual for js files to carry license headers similar to Java files? If so, could you add an EPL header?
  2. How is the skill used? "Alexa, tell openHAB to..."? Does she recognize this well? Or are we free to come up with any fantasy name for openHAB in Alexa?

### Create issues...

Any significant improvement should be documented as [a GitHub
issue](https://github.com/openhab/openhab-docker/issues?labels=enhancement&page=1&state=open) before anybody
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not again docker ;-)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry i just blindly copied this from the openhab-cloud project!

This is a Amazon Alexa Smarthome skill for openHAB 2.

# General Installation Instructions
## Requirements
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add an empty line after every headline and before and after every code section as otherwise Jekyll will mess up the formatting.

{
"name": "openHAB.alexa-smarthome",
"version": "0.0.1",
"description": "An Amazon Smart Home API implementation for OpenHAB",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

openHAB, not OpenHAB

"main": "index.js",
"repository": {
"type": "git",
"url": "https://github.com/digitaldan/openhab.alexa-smart-home.git"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

err, that url looks outdated...

"turnOff"
],
"applianceId": "ECHO_Switch_All_Lights",
"manufacturerName": "OpenHAB",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

openHAB, not OpenHAB.

"modelName": "Switch",
"version": "1",
"friendlyName": "All Lights",
"friendlyDescription": "Switch All Lights via OpenHAB",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

openHAB, not OpenHAB.
You have many more such occurrences, please do a search replace :-)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry all the samples/responses/ were not added by me, and now that I think about are not very useful here, I will remove completely.

@digitaldan
Copy link
Collaborator Author

Is it usual for js files to carry license headers similar to Java files? If so, could you add an EPL header?

Yes this can be done

How is the skill used? "Alexa, tell openHAB to..."? Does she recognize this well? Or are we free to come up with any fantasy name for openHAB in Alexa?

This uses the Smarthome API, which means no application word, so you simply say "Alexa turn kitchen lights on"

Signed-off-by: Dan Cunningham <dan@digitaldan.com>
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
@digitaldan
Copy link
Collaborator Author

@kaikreuzer if you are all good I can (or you) merge this.

Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, just very minor comments left


* openHAB 2
* Items are exposed via Homekit tags, the following is taken from the homekit binding in openHAB2:
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty line missing

Number DownstairsThermostatTargetTemperature "Downstairs Thermostat Target Temperature" (gDownstairsThermostat) [ "TargetTemperature" ]
String DownstairsThermostatHeatingCoolingMode "Downstairs Thermostat Heating/Cooling Mode" (gDownstairsThermostat) [ "homekit:HeatingCooling
```
* By default all temperatures are in Celsius, for Fahrenheit add the tag `temperatureFormat:fahrenheit` to the thermostat group item (which should also be tagged with `Thermostat`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty line missing



## Example Voice Commands
Here are some example voice commands:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty line missing

*/

/**
*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove empty doc lines?

Signed-off-by: Dan Cunningham <dan@digitaldan.com>
@digitaldan
Copy link
Collaborator Author

Hopefully that does it!

Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful :-)

@kaikreuzer kaikreuzer merged commit b873535 into openhab:master Dec 1, 2016
jsetton referenced this pull request in jsetton/openhab-alexa Apr 21, 2018
Fix v3 thermostat handling.
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants