-
-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial commit #1
Conversation
114ba3c
to
e0b74f4
Compare
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
e0b74f4
to
4a9eede
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, can't wait to get that in place!
Besides my comments, two questions:
- Is it usual for js files to carry license headers similar to Java files? If so, could you add an EPL header?
- How is the skill used? "Alexa, tell openHAB to..."? Does she recognize this well? Or are we free to come up with any fantasy name for openHAB in Alexa?
### Create issues... | ||
|
||
Any significant improvement should be documented as [a GitHub | ||
issue](https://github.com/openhab/openhab-docker/issues?labels=enhancement&page=1&state=open) before anybody |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not again docker ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry i just blindly copied this from the openhab-cloud project!
This is a Amazon Alexa Smarthome skill for openHAB 2. | ||
|
||
# General Installation Instructions | ||
## Requirements |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add an empty line after every headline and before and after every code section as otherwise Jekyll will mess up the formatting.
{ | ||
"name": "openHAB.alexa-smarthome", | ||
"version": "0.0.1", | ||
"description": "An Amazon Smart Home API implementation for OpenHAB", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
openHAB, not OpenHAB
"main": "index.js", | ||
"repository": { | ||
"type": "git", | ||
"url": "https://github.com/digitaldan/openhab.alexa-smart-home.git" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
err, that url looks outdated...
"turnOff" | ||
], | ||
"applianceId": "ECHO_Switch_All_Lights", | ||
"manufacturerName": "OpenHAB", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
openHAB, not OpenHAB.
"modelName": "Switch", | ||
"version": "1", | ||
"friendlyName": "All Lights", | ||
"friendlyDescription": "Switch All Lights via OpenHAB", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
openHAB, not OpenHAB.
You have many more such occurrences, please do a search replace :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry all the samples/responses/ were not added by me, and now that I think about are not very useful here, I will remove completely.
Yes this can be done
This uses the Smarthome API, which means no application word, so you simply say "Alexa turn kitchen lights on" |
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
@kaikreuzer if you are all good I can (or you) merge this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, just very minor comments left
|
||
* openHAB 2 | ||
* Items are exposed via Homekit tags, the following is taken from the homekit binding in openHAB2: | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
empty line missing
Number DownstairsThermostatTargetTemperature "Downstairs Thermostat Target Temperature" (gDownstairsThermostat) [ "TargetTemperature" ] | ||
String DownstairsThermostatHeatingCoolingMode "Downstairs Thermostat Heating/Cooling Mode" (gDownstairsThermostat) [ "homekit:HeatingCooling | ||
``` | ||
* By default all temperatures are in Celsius, for Fahrenheit add the tag `temperatureFormat:fahrenheit` to the thermostat group item (which should also be tagged with `Thermostat`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
empty line missing
|
||
|
||
## Example Voice Commands | ||
Here are some example voice commands: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
empty line missing
*/ | ||
|
||
/** | ||
* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove empty doc lines?
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
Hopefully that does it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonderful :-)
Fix v3 thermostat handling.
Signed-off-by: Dan Cunningham dan@digitaldan.com