New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notification received while app is running kills the app #853
Comments
Can you please show a screenshot of what you mean by 'the message clicked OK'? Thanks. |
Indeed, it shouldn't come up. You can't collect logcat after that incidence by chance, can you? Edit: thinking about it, 'Angehalten' likely is a crash. What Android version is this? And I assume the notification was created by sending a test message from the web page in the background and not by OpenHAB itself? |
@JueBag Which device and Android version do you use? @maniac103 There is only one ANR for the 2.1.0 version:
There are a lot of stacktraces show for this anr, but none of them contain lines about the org.openhab.habdroid package. |
@mueller-ma May I get read-only access to the Play Store console so I can check the crashes myself? If yes, how can I non-publically tell you my Gmail address? |
Yes I was sending the messages from the myopenhab page. Used it from one device to the other. |
Got LogCat, recorded while sending a message from the webpage. However I can't see anything in that log, except maybe an entry "Input channel destroyed" (but I'm new to this.) |
While it makes sense to give you access to stacktraces, @kaikreuzer needs to decide that. |
You likely captured logcat via non-root app (be it a terminal emulator or something like MatLog). In that case, the captured log only contains log line of that app. You'll need either root or capture via 'adb logcat' on a PC. |
Yes, my devices are not rooted. Since I'm away from my PC (Scotland atm) I can't help on that topic. Sorry |
I can reproduce, so never mind :-) I've seen that particular issue before, and thought I fixed it at some point, but the fix probably got lost during rebasing or in some refactor. I'll fix it. |
9c683b2 is the commit I thought of. It didn't get lost, but is not sufficient either: it should check for 'cloud connection present && started' before opening the notifications pane. |
PR openhab#789 attempted to fix this already, but was incomplete: if a notification was clicked and the cloud connection already was resolved at the time the activity was created (which may or may not have happened, as activity creation in main thread and cloud connection resolving in update thread race against each other), fragment updates happened even though the activity wasn't started yet. Fix this by tracking explicitly whether the activity is started, and deferring updates until then. Closes openhab#853 Signed-off-by: Danny Baumann <dannybaumann@web.de>
…855) PR #789 attempted to fix this already, but was incomplete: if a notification was clicked and the cloud connection already was resolved at the time the activity was created (which may or may not have happened, as activity creation in main thread and cloud connection resolving in update thread race against each other), fragment updates happened even though the activity wasn't started yet. Fix this by tracking explicitly whether the activity is started, and deferring updates until then. Closes #853 Signed-off-by: Danny Baumann <dannybaumann@web.de>
@maniac103 You should have received a mail from me. |
Just tested the restarted notification service and found a problem.
If the app is running in background while the message is received followed by the message clicked OK, the app gets either stopped or a selection window gets displayed asking for stopping the app or giving fedback (checking on two different android devices)
App Version 2.1.0
The text was updated successfully, but these errors were encountered: