Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Tasker/Locale action plugin #1338

Merged
merged 16 commits into from Jun 4, 2019
Merged

Add Tasker/Locale action plugin #1338

merged 16 commits into from Jun 4, 2019

Conversation

mueller-ma
Copy link
Member

@mueller-ma mueller-ma commented May 4, 2019 •
edited

This plugin works with
https://play.google.com/store/apps/details?id=com.twofortyfouram.locale
and
https://play.google.com/store/apps/details?id=net.dinglisch.android.taskerm.

See #257

Signed-off-by: mueller-ma mueller-ma@users.noreply.github.com

TODO:

  • Make list searchable
  • Hide read-only items
  • Add more predefined states to pick from
  • Add feature to docs and app store description?

@mueller-ma mueller-ma added the enhancement Indicates new feature requests label May 4, 2019
@mueller-ma
Copy link
Member Author

Here's the apk: mobile-foss-beta-debug.zip

  • Rename it to .apk
  • Uninstall openHAB Beta if installed
  • Install my apk

@mueller-ma mueller-ma mentioned this pull request May 4, 2019
Closed
@Confectrician
Copy link

Confectrician commented May 4, 2019 •
edited

Works already very well.
Would it be possible to also GET an item state instead of only setting one?

@mueller-ma
Copy link
Member Author

Would it be possible to also GET an item state instead of only setting one?

That would be a condition plugin. Yes, it's possible, but not in this PR.

@Confectrician
Copy link

That would be a condition plugin. Yes, it's possible, but not in this PR.

Ah sorry, i think we have discussed this already somewhere.
I remember now.
Thanks for clarifiaction.

@mueller-ma
Copy link
Member Author

Maybe I should add a pref to enable this plugin. Otherwise any app can send item updates.

@mueller-ma mueller-ma force-pushed the 257-tasker-action branch 2 times, most recently from 4ffe7f7 to 87d3d73 Compare May 19, 2019 15:36
@mueller-ma mueller-ma changed the title WIP: Add Tasker/Locale action plugin Add Tasker/Locale action plugin May 19, 2019
@mueller-ma mueller-ma mentioned this pull request May 20, 2019
Merged
maniac103
maniac103 requested changes May 21, 2019
View reviewed changes
assets/store_descriptions/en-US/strings.xml Outdated Show resolved Hide resolved
mobile/src/main/java/org/openhab/habdroid/model/Item.java Outdated Show resolved Hide resolved
mobile/src/main/java/org/openhab/habdroid/ui/ItemPickerActivity.java Outdated Show resolved Hide resolved
mobile/src/main/java/org/openhab/habdroid/ui/ItemPickerAdapter.java Outdated Show resolved Hide resolved
mobile/src/main/java/org/openhab/habdroid/ui/ItemPickerAdapter.java Show resolved Hide resolved
mobile/src/main/java/org/openhab/habdroid/util/SuggestCommandsFactory.java Outdated Show resolved Hide resolved
mobile/src/main/java/org/openhab/habdroid/util/SuggestCommandsFactory.java Outdated Show resolved Hide resolved
mobile/src/main/java/org/openhab/habdroid/ui/ItemPickerAdapter.java Outdated Show resolved Hide resolved
mobile/src/main/java/org/openhab/habdroid/ui/ItemPickerAdapter.java Outdated Show resolved Hide resolved
mobile/src/main/java/org/openhab/habdroid/ui/ItemPickerAdapter.java Outdated Show resolved Hide resolved
@mueller-ma
Copy link
Member Author

mueller-ma commented May 28, 2019 •
edited

TODO:

  • Auto open/hide keyboard on clicking "Custom"
  • Fix UoM: Units aren't sent to server for Setpoints with units: Demo package > Widget Overview > Temperature (Setpoint). UoM don't work here as well.

@mueller-ma
Copy link
Member Author

Maybe I should add a pref to enable this plugin. Otherwise any app can send item updates.

@maniac103 WDYT?

@maniac103
Copy link
Contributor

@mueller-ma I agree, making this opt-in sounds like a good idea. Pref naming suggestion: 'Tasker integration' with summary 'Enable Tasker action plugin which allows updating Items via Tasker.' ... and only show it if either the pref is enabled at page enter time or Tasker is installed.

@mueller-ma
Copy link
Member Author

Should something happen if an app wants to update an item without permission, e.g. show a toast?

@maniac103
Copy link
Contributor

I personally wouldn't do it. If the plugin is disabled, just treat it as such and keep it as silent as possible.

@mueller-ma
Add Tasker/Locale action plugin
5d2f4ad 
This plugin works with
https://play.google.com/store/apps/details?id=com.twofortyfouram.locale
and
https://play.google.com/store/apps/details?id=net.dinglisch.android.taskerm.

See openhab#257

Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>
@mueller-ma
Hide read-only items
3e7f178 
Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>
@mueller-ma
Code style
844d250 
Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>
@mueller-ma
Optimize imports
49be35c 
Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>
@mueller-ma
Add more suggested commands
5d2c4f4 
Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>
@mueller-ma
Add feature to docs and app store description
1f9227e 
Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>
@mueller-ma
Fix python script
f1dca8c 
Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>
@mueller-ma
Make list searchable
13c71b3 
Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>
@mueller-ma
Implement review comments
c858eab 
Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>
@mueller-ma
Don't set LinearLayout.LayoutParams
59c290e 
Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>
@mueller-ma
Improve SuggestedCommandsFactory
6c6452f 
* Fix typo in name
* Return a SuggestedCommands object
* Set input type for edit text
* Hide "Custom" if not needed

Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>
@mueller-ma
Save SuggestedCommandsFactory instance
6d8f5f6 
Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>
@mueller-ma
Show keyboard if custom dialog is opened
dda2a3e 
Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>
@mueller-ma
Code Style
9f59608 
Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>
@mueller-ma
Add pref to enable plugin
d26eba4 
Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>
@mueller-ma
Copy link
Member Author

RTM from my side.

@mueller-ma
Code Style
8b216df 
Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>
maniac103
maniac103 approved these changes Jun 4, 2019
View reviewed changes
Copy link
Contributor

@maniac103 maniac103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pref changes look good to me ... Ship it 👍

@mueller-ma mueller-ma merged commit e9addf5 into openhab:master Jun 4, 2019
@mueller-ma mueller-ma deleted the 257-tasker-action branch June 4, 2019 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maniac103 maniac103 maniac103 approved these changes

Assignees
No one assigned
Labels
enhancement Indicates new feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mueller-ma @Confectrician @maniac103