Use DayNight themes #1547

mueller-ma · 2019-09-21T16:00:03Z

Fixes #873
Fixes #1058
Closes #1431

TODO:

Fix crash when opening About on Android 5
Fix section switch widgets

mueller-ma · 2019-09-24T19:34:44Z

maniac103

Section switch height is due to the Widget.MaterialComponents.CompoundButton.RadioButton style having a android:minHeight of 48dp set. We can/should override this in widgetlist_sectionswitchitem_button.xml.

I'm still not really convinced that the accent color selection is a useful addition (for the same reasons as mentioned earlier, but it looks like it's important to you?

mobile/src/main/res/values/themes.xml

mobile/src/main/java/org/openhab/habdroid/ui/PreferencesActivity.kt

mueller-ma · 2019-09-26T12:09:43Z

We can/should override this in widgetlist_sectionswitchitem_button.xml.

👍

I'm still not really convinced that the accent color selection is a useful addition (for the same reasons as mentioned earlier, but it looks like it's important to you?

It's possible to change the accent color with the current implementation and it's also possible to the Basic UI and many other UIs. Thus I don't want to remove this feature from the app.

maniac103 · 2019-09-26T12:58:56Z

It's possible to change the accent color with the current implementation

Yes, but only between a set of color schemes related to openHAB.

and it's also possible to the Basic UI and many other UIs.

Where can one change the Basic UI color scheme? I've only ever seen such settings in some Android apps not affiliated to a certain project or company so far.

Thus I don't want to remove this feature from the app.

You want to add this feature; that's not the same thing as not removing it. One currently can't select arbitrary color schemes.

mueller-ma · 2019-09-26T14:23:32Z

Where can one change the Basic UI color scheme? I've only ever seen such settings in some Android apps not affiliated to a certain project or company so far.

I've misread a PR for theming Basic UI: eclipse-archived/smarthome#4137
The colors didn't make it through review, only bright and dark mode. I reduced the accent colors to orange, blue (like Basic UI) and grey (like the old grey theme).

maniac103 · 2019-09-26T14:56:07Z

I've misread a PR for theming Basic UI: eclipse-archived/smarthome#4137
The colors didn't make it through review, only bright and dark mode.

Heh, I see Kai shared my concerns in https://github.com/eclipse/smarthome/pull/4137/files#r137015539 ;-)

I reduced the accent colors to orange, blue (like Basic UI) and grey (like the old grey theme).

Nice. Now we just need to restore the pink accent color in the blue theme to make it consistent to BasicUI and we're set, I think.

maniac103

Found a few additional small things.

I also wonder whether we shouldn't go to minSdkVersion 21 ... doing so allows using color resources or attributes in vector drawables, which means we could drop all -night drawables.

mobile/src/androidTest/java/org/openhab/habdroid/ui/WidgetAdapterTest.kt

mobile/src/main/java/org/openhab/habdroid/core/UpdateBroadcastReceiver.kt

mobile/src/main/res/layout/item_updating_pref_dialog.xml

mueller-ma · 2019-09-27T10:54:46Z

I also wonder whether we shouldn't go to minSdkVersion 21

I'd like to keep this for now.

mobile/src/main/java/org/openhab/habdroid/ui/preference/ItemUpdatingPreference.kt

maniac103 · 2019-09-28T18:43:00Z

Hmm, opening settings has a delay of at least half a second on a fairly fast device (OnePlus 6). This seems too much for my taste, and I don't think it's always been like that, right?

Edit: Looks like this is unrelated -> #1563

mobile/src/main/java/org/openhab/habdroid/ui/AbstractBaseActivity.kt

maniac103 · 2019-09-30T08:50:22Z

Got 2 additional optimization commits to pull: https://github.com/maniac103/openhab.android/commits/dark-mode ... the 'avoid recreation' one was inspired by advice in https://medium.com/androiddevelopers/appcompat-v23-2-daynight-d10f90c83e94

Fixes openhab#873 Fixes openhab#1058 Closes openhab#1431 Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>

Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>

Signed-off-by: Danny Baumann <dannybaumann@web.de>

Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>

Signed-off-by: Danny Baumann <dannybaumann@web.de>

In particular, avoid recreating activities if possible. Signed-off-by: Danny Baumann <dannybaumann@web.de>

The "Select" button in the accent color picker in a dark theme and grey as accent color is hardly visible. Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>

Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>

mueller-ma added the enhancement Indicates new feature requests label Sep 21, 2019

maniac103 requested changes Sep 26, 2019

View reviewed changes

mobile/src/main/res/values/themes.xml Outdated Show resolved Hide resolved

mobile/src/main/java/org/openhab/habdroid/ui/PreferencesActivity.kt Show resolved Hide resolved

maniac103 reviewed Sep 27, 2019

View reviewed changes

mobile/src/main/java/org/openhab/habdroid/ui/preference/ItemUpdatingPreference.kt Outdated Show resolved Hide resolved

mueller-ma force-pushed the dark-mode branch from a370da6 to df379a8 Compare September 27, 2019 11:04

mueller-ma changed the title ~~Use DayNight themes and add more accent colors~~ Use DayNight themes Sep 27, 2019

maniac103 reviewed Sep 29, 2019

View reviewed changes

mobile/src/main/java/org/openhab/habdroid/ui/AbstractBaseActivity.kt Outdated Show resolved Hide resolved

mueller-ma mentioned this pull request Sep 30, 2019

Update OkHttp to latest version. #1564

Merged

mueller-ma force-pushed the dark-mode branch 2 times, most recently from c2f5334 to 939ef16 Compare September 30, 2019 14:46

mueller-ma and others added 12 commits October 2, 2019 08:12

Use DayNight themes and add more accent colors

078b69d

Fixes openhab#873 Fixes openhab#1058 Closes openhab#1431 Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>

Fix test

aabc19c

Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>

Implement review comments

bd673cc

Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>

Remove a few accent colors

90ee909

Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>

Use color res and restore pink accent color

ea5dbc0

Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>

Use shortcut in when

80fad7c

Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>

Fix test

f9ecb74

Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>

Beautify text input preferences.

3eae604

Signed-off-by: Danny Baumann <dannybaumann@web.de>

Restore warnings after opening preference

d9aa8b3

Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>

Use new editor error

832f1f0

Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>

Code Style

12a4d84

Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>

Change versionCode

f09efd5

Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>

mueller-ma and others added 4 commits October 2, 2019 08:12

Code Style

5e8fc64

Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>

Simplify dark theme color mapper test.

faffea2

Signed-off-by: Danny Baumann <dannybaumann@web.de>

Optimize dark mode changing.

0a4be7f

In particular, avoid recreating activities if possible. Signed-off-by: Danny Baumann <dannybaumann@web.de>

Use a brighter grey

337c54e

The "Select" button in the accent color picker in a dark theme and grey as accent color is hardly visible. Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>

mueller-ma force-pushed the dark-mode branch from 939ef16 to 337c54e Compare October 2, 2019 06:12

Fix rebase mistake

977d4a0

Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>

mueller-ma merged commit 407a91f into openhab:master Oct 2, 2019

mueller-ma deleted the dark-mode branch October 2, 2019 10:14

maniac103 mentioned this pull request Oct 4, 2019

Support flexible color theming and/or a widened selection of accent colors #1591

Closed

maniac103 mentioned this pull request Feb 13, 2021

Allow more color options #2456

Closed

maniac103 mentioned this pull request Feb 8, 2023

Reintroduce theme selection #3178

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use DayNight themes #1547

Use DayNight themes #1547

mueller-ma commented Sep 21, 2019 •

edited

mueller-ma commented Sep 24, 2019

maniac103 left a comment

mueller-ma commented Sep 26, 2019

maniac103 commented Sep 26, 2019

mueller-ma commented Sep 26, 2019

maniac103 commented Sep 26, 2019

maniac103 left a comment

mueller-ma commented Sep 27, 2019

maniac103 commented Sep 28, 2019 •

edited

maniac103 commented Sep 30, 2019 •

edited

Use DayNight themes #1547

Use DayNight themes #1547

Conversation

mueller-ma commented Sep 21, 2019 • edited

mueller-ma commented Sep 24, 2019

maniac103 left a comment

Choose a reason for hiding this comment

mueller-ma commented Sep 26, 2019

maniac103 commented Sep 26, 2019

mueller-ma commented Sep 26, 2019

maniac103 commented Sep 26, 2019

maniac103 left a comment

Choose a reason for hiding this comment

mueller-ma commented Sep 27, 2019

maniac103 commented Sep 28, 2019 • edited

maniac103 commented Sep 30, 2019 • edited

mueller-ma commented Sep 21, 2019 •

edited

maniac103 commented Sep 28, 2019 •

edited

maniac103 commented Sep 30, 2019 •

edited