Fixes #218 #226
Merged
Fixes #218 #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CristianSarac
changed the title
|
Hi @CristianSarac , sorry for the very long delay! LGTM, do you foresee any issues if the messages were very very long? Not sure if this is an actual use case. |
|
The only issue i can foresee is that, if some notifications would have a longer message then others then the list wouldn't be symmetric meaning that one would be bigger( in order to fit the message) and others smaller is size depending on the size of the message. |
|
I will go ahead and merge soon, thanks again for the PR! |
mgarciate
pushed a commit
to mgarciate/openhab.android
that referenced
this pull request
May 22, 2017
* 'master' of https://github.com/openhab/openhab.android: (31 commits) Do not start discovery service if only remote url is configured (openhab#291) Implement dynamic GCM sender ID (openhab#288) Updates gradle plugin to latest 2.4.0-alpha7 (openhab#296) Update to latest API+tools+gradle+misc. (try openhab#2) (openhab#281) set default theme to light (openhab#292) make "icon format" in settings translatable (openhab#293) Make a few strings non-translatable (openhab#277) Revert "Update to latest API+tools+gradle+misc. (openhab#268)" (openhab#280) More consistent strings (openhab#276) Update to latest API+tools+gradle+misc. (openhab#268) Bump verion for next relese (openhab#273) References openhab#117 - restore NFC functionality to Switch items (openhab#267) Add Lithuanian translation (openhab#272) Support for icons in svg format (openhab#256) Improve WebView compatibility by enabling DOM storage (openhab#266) Fix attempt at openhab#116 (openhab#262) Added Japanese translation (openhab#254) updated german translation (openhab#259) Bump version for next release. Signed-off-by: Cristian Sarac <sarac.cristian@gmaill.com> github: CristianSarac (openhab#226) ... # Conflicts: # mobile/src/main/res/values-es/strings.xml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #218