Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vertical alignment and value spacing of compact-mode switch buttons #3574

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Jan 22, 2024

Before:

  • The value appears to not be vertically centered against the button, especially against the labels inside the buttons)
  • The value is too close to the buttons
Screenshot 2024-01-22 at 6 04 50 pm

After:

  • Removed the top padding of the buttons, thus bringing them higher and centered against the value to its left
  • Added some spacing between the value and the buttons
Screenshot 2024-01-22 at 6 20 34 pm

How it looks (after) with icons:
Screenshot 2024-01-22 at 6 20 12 pm


Before:
The value is too close to the on/off button
Screenshot 2024-01-22 at 6 14 44 pm

After:
Added some spacing between the value and the buttons
Screenshot 2024-01-22 at 6 18 26 pm

Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Copy link
Member

@mueller-ma mueller-ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mueller-ma mueller-ma merged commit d1510e2 into openhab:main Jan 22, 2024
7 checks passed
@jimtng jimtng deleted the switch-compact-valign branch May 23, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants