Translate f7 underscores into iconify style dashes #3603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f7 icons use underscores. When they're imported into iconify, the underscores became dashes. When user actually specified `f7:icon_name` it should work without them having to know that we implemented it with iconify. Alternatively users can use `iconify:f7:icon-name` with dashes. If they had specified `f7:icon-name` that would still to work too. Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
f7 icons use underscores. When they're imported into iconify, the underscores became dashes.
When user actually specified
f7:icon_nameit should work without them having to know that we implemented it with iconify.Alternatively users can use
iconify:f7:icon-namewith dashes.If they had specified
f7:icon-namethat would still to work too.