New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[persistence] averageSince shouldn't return null #1333
Comments
To find an answer why As the calculation considers the current value - if known - imo it would make sense to return the current value instead. Maybe @J-N-K can elaborate on this topic. I think we have to change the JavaDocs anyway because the other method says to return Lines 400 to 403 in 2c8de49
|
Signed-off-by: Jerome Luckenbach <github@luckenba.ch>
The problem with returning the current value is that this might be wrong. The calculation is essentially the integral of values over time |
I re-read the old discussion on ESH and I think the consensus reached is still valid. I'll adjust the JavaDoc. |
The JavaDoc says that the Items state will be returned if it has not changed since the DateTime specified, but it returns null. This should be changed. Changing the docs would be easy, but I think this would be better functionality.
The text was updated successfully, but these errors were encountered: