Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent AddonType for "io" bundles in Karaf & Marketplace add-on services #2507

Closed
ghys opened this issue Oct 5, 2021 · 2 comments · Fixed by #2508
Closed

Inconsistent AddonType for "io" bundles in Karaf & Marketplace add-on services #2507

ghys opened this issue Oct 5, 2021 · 2 comments · Fixed by #2508
Labels
bug An unexpected problem or unintended behavior of the Core

Comments

@ghys
Copy link
Member

ghys commented Oct 5, 2021

The "io" bindings are set to the "io" AddonType in the CommuntiyMarketplaceAddonService:

private static final List<String> SUPPORTED_EXT_TYPES = List.of("automation", "binding", "io", "persistence",
"transformation", "ui", "voice");

While in the Karaf add-on service they are set as "misc":

typeList.add(new AddonType(FeatureInstaller.EXTENSION_TYPE_MISC, "Misc"));

@wborn that's why https://community.openhab.org/t/log4j2-extra/127214 didn't appear in the "Other" tab of the UI when you added the "io" tag (it displays the "misc" add-ons under "System Integrations", not "io").

@wborn
Copy link
Member

wborn commented Oct 5, 2021

Yes that's why I switched the category and was also looking into what happend. 👍

@wborn wborn added the bug An unexpected problem or unintended behavior of the Core label Oct 5, 2021
@openhab-bot
Copy link
Collaborator

This issue has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/basic-profiles-smarthome-j-version/127317/2

cweitkamp pushed a commit that referenced this issue Oct 8, 2021
* Fix add-on type inconsistencies

This makes the CommunityMarketplaceAddonService return the same add-on type responses as the KarafAddonService.
This allows for add-ons tagged with "io" in the Marketplace to show up in the UI.

Fixes #2507

* Update "io" tag to "misc"

Signed-off-by: Wouter Born <github@maindrain.net>
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this issue Jul 12, 2023
* Fix add-on type inconsistencies

This makes the CommunityMarketplaceAddonService return the same add-on type responses as the KarafAddonService.
This allows for add-ons tagged with "io" in the Marketplace to show up in the UI.

Fixes openhab#2507

* Update "io" tag to "misc"

Signed-off-by: Wouter Born <github@maindrain.net>
GitOrigin-RevId: 5afa5fe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of the Core
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants