New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce core framework metrics #774
Comments
@pokerazor How much effort would it be to port your implementation to the Eclipse MicroProfile API? I only mean the provider side, not the consuming part. |
Hm. Very hard to say for me, as I don't have experience with the Eclipse MicroProfile API ... how could we approach this? What is the aim? What is the downside of using what is currently implemented in the bundle? |
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
Following up on the discussion in #2065 here:
@kaikreuzer
Why do you write "must not"? What's the downside? I'll try to push my WIP version tonight. |
@kaikreuzer What do you think about using Micrometer instead of MicroProfile Metrics? |
@pravussum Sounds like a very good point. The situation has changed since the initial discussion a few years back and Micrometer seems indeed being the preferred API for all the frameworks out there - so yes, heading for Micrometer sounds perfectly reasonable! |
Signed-off-by: Robert Bach <openhab@mortalsilence.net>
Signed-off-by: Robert Bach <openhab@mortalsilence.net>
Signed-off-by: Robert Bach <openhab@mortalsilence.net>
Signed-off-by: Robert Bach <openhab@mortalsilence.net>
Signed-off-by: Robert Bach <openhab@mortalsilence.net>
This issue has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/new-add-on-bundle-for-prometheus-health-metrics/48094/46 |
Implemented with #2133. |
Signed-off-by: Robert Bach <openhab@mortalsilence.net> GitOrigin-RevId: f061512
Follow up of this discussion.
We should make use of Eclipse MicroProfile metrics API and provide all kinds of core metrics from openHAB this way - like CPU usage, heap size, number of threads, job queue sizes, event throughput, etc.
Once such information is provided through the API, we can use it to e.g. provide a Prometheus publisher, to provide it through JMX or directly integrate it into the systeminfo binding.
The text was updated successfully, but these errors were encountered: