Allow persistence services to define default strategies #1387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kai Kreuzer <kai@openhab.org>
Signed-off-by: Kai Kreuzer <kai@openhab.org>
cweitkamp
added
enhancement
cweitkamp
reviewed
Mar 8, 2020
| * | ||
| * @return The default persistence strategies | ||
| */ | ||
| List<PersistenceStrategy> getDefaultStrategies(); |
There was a problem hiding this comment.
I know that this PR is APIBreaking anyways but you also can add the default method implementation here:
Suggested change
| List<PersistenceStrategy> getDefaultStrategies(); | |
| default List<PersistenceStrategy> getDefaultStrategies() { | |
| return Collections.emptyList(); | |
| } |
Be aware of an eventually missing import.
There was a problem hiding this comment.
I thought about this, but I decided against it. Problem with the default methods is that no method skeleton is created in implementing classes, so that developers are not aware that they should actually think about implementing the method.
...g.openhab.core.persistence/src/main/java/org/openhab/core/persistence/PersistenceFilter.java
Show resolved
Hide resolved
....persistence/src/main/java/org/openhab/core/persistence/internal/PersistenceManagerImpl.java
Outdated
Show resolved
Hide resolved
....persistence/src/main/java/org/openhab/core/persistence/internal/PersistenceManagerImpl.java
Outdated
Show resolved
Hide resolved
…/core/persistence/internal/PersistenceManagerImpl.java Co-Authored-By: Christoph Weitkamp <github@christophweitkamp.de>
…/core/persistence/internal/PersistenceManagerImpl.java Co-Authored-By: Christoph Weitkamp <github@christophweitkamp.de>
Signed-off-by: Kai Kreuzer <kai@openhab.org>
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/openhab3-first-feedback-on-editing-entities/105075/27 |
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 11, 2023
…openhab#1387) * Allow persistence services to define default strategies * Added null annotations Signed-off-by: Kai Kreuzer <kai@openhab.org> GitOrigin-RevId: 427e969
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also refactored Simple... classes to Persistence.... classes (that's actually 95% of the changes).
Signed-off-by: Kai Kreuzer kai@openhab.org