Removed dependency on 'org.apache.commons.io' #1441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cweitkamp
added
work in progress
cweitkamp
commented
Apr 22, 2020
bundles/org.openhab.core.id/src/main/java/org/openhab/core/id/InstanceUUID.java
Outdated
Show resolved
Hide resolved
cweitkamp
commented
Apr 22, 2020
...penhab.core.io.rest.auth/src/main/java/org/openhab/core/io/rest/auth/internal/JwtHelper.java
Outdated
Show resolved
Hide resolved
cweitkamp
commented
Apr 22, 2020
...onfig.dispatch/src/main/java/org/openhab/core/config/dispatch/internal/ConfigDispatcher.java
Show resolved
Hide resolved
cweitkamp
commented
Apr 22, 2020
....tests/src/main/java/org/openhab/core/config/dispatch/internal/ConfigDispatcherOSGiTest.java
Show resolved
Hide resolved
cweitkamp
changed the title
cweitkamp
commented
Apr 25, 2020
| try { | ||
| Files.writeString(file.toPath(), content, StandardCharsets.UTF_8); | ||
| } catch (IOException ioe) { | ||
| LOGGER.warn("Failed writing to file '{}': {}", content, file.getAbsolutePath(), ioe.getMessage()); |
There was a problem hiding this comment.
Suggested change
| LOGGER.warn("Failed writing to file '{}': {}", content, file.getAbsolutePath(), ioe.getMessage()); | |
| LOGGER.warn("Failed writing to file '{}': {}", file.getAbsolutePath(), ioe.getMessage()); |
cpmeister
reviewed
May 6, 2020
bundles/org.openhab.core.audio/src/main/java/org/openhab/core/audio/URLAudioStream.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.core.audio/src/main/java/org/openhab/core/audio/URLAudioStream.java
Outdated
Show resolved
Hide resolved
....core.model.core/src/main/java/org/openhab/core/model/core/internal/ModelRepositoryImpl.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.core.model.script/src/org/openhab/core/model/script/actions/HTTP.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.core.model.script/src/org/openhab/core/model/script/actions/HTTP.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.core.model.script/src/org/openhab/core/model/script/actions/HTTP.java
Outdated
Show resolved
Hide resolved
....openhab.core.thing/src/main/java/org/openhab/core/thing/internal/firmware/FirmwareImpl.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.core.model.script/src/org/openhab/core/model/script/actions/HTTP.java
Outdated
Show resolved
Hide resolved
cweitkamp
force-pushed
the
feature-remove-apache-commons-io
branch
from
dea4b40
to
d0db372
Compare
|
@cpmeister Thanks for the useful review. I rebased and incorporated all suggested changes. |
cpmeister
suggested changes
May 8, 2020
| return newKey; | ||
| } | ||
|
|
||
| private RsaJsonWebKey loadOrGenerateKey() throws FileNotFoundException, JoseException, IOException { | ||
| try { | ||
| List<String> lines = IOUtils.readLines(new FileInputStream(KEY_FILE_PATH)); | ||
| return (RsaJsonWebKey) JsonWebKey.Factory.newJwk(lines.get(0)); | ||
| final BufferedReader reader = Files.newBufferedReader(Paths.get(KEY_FILE_PATH)); |
There was a problem hiding this comment.
You should also close this reader after you are done with it
16 tasks
wborn
approved these changes
May 20, 2020
There was a problem hiding this comment.
The changes look very good to me @cweitkamp! 👍
So when the conflicts are resolved we should be able to merge this.
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
cweitkamp
force-pushed
the
feature-remove-apache-commons-io
branch
from
d7f6d00
to
d4109ee
Compare
|
@wborn I resolved all conflicts. Unfortunately I had to squash my commits to simplify the rebase. |
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/guide-binding-development-changes-for-openhab-3-from-2-5-x/104134/4 |
t-8ch
added a commit
to t-8ch/openhab-binding-wmbus
that referenced
this pull request
May 16, 2021
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 11, 2023
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> GitOrigin-RevId: 8808f04
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed dependency on
org.apache.commons.iobom/compile/pom.xml
bom/compile/pom.xml
features/karaf/openhab-tp/src/main/feature/feature.xml
Resolve
itest.bndrunSigned-off-by: Christoph Weitkamp github@christophweitkamp.de