Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed unused mapdb storage bundle #1488

Merged
merged 2 commits into from
May 22, 2020
Merged

removed unused mapdb storage bundle #1488

merged 2 commits into from
May 22, 2020

Conversation

kaikreuzer
Copy link
Member

@kaikreuzer
removed unused mapdb storage bundle
5066ceb 
Signed-off-by: Kai Kreuzer <kai@openhab.org>
@kaikreuzer kaikreuzer requested a review from wborn May 20, 2020 21:41
@wborn
Copy link
Member

wborn commented May 21, 2020 •
edited
Loading

The feature verification wants to have a StorageService implementation:

[ERROR] Message: Unable to resolve root: missing requirement [root] osgi.identity; osgi.identity=openhab-core-base; type=karaf.feature; version=3.0.0.SNAPSHOT; filter:="(&(osgi.identity=openhab-core-base)(type=karaf.feature)(version>=3.0.0.SNAPSHOT))" [caused by: Unable to resolve openhab-core-base/3.0.0.SNAPSHOT: missing requirement [openhab-core-base/3.0.0.SNAPSHOT] osgi.identity; osgi.identity=org.openhab.core.config.discovery; type=osgi.bundle; version="[3.0.0.202005202144,3.0.0.202005202144]"; resolution:=mandatory [caused by: Unable to resolve org.openhab.core.config.discovery/3.0.0.202005202144: missing requirement [org.openhab.core.config.discovery/3.0.0.202005202144] osgi.wiring.package; filter:="(&(osgi.wiring.package=org.openhab.core.common.registry)(version>=3.0.0)(!(version>=4.0.0)))" [caused by: Unable to resolve org.openhab.core/3.0.0.202005202143: missing requirement [org.openhab.core/3.0.0.202005202143] osgi.service; filter:="(objectClass=org.openhab.core.storage.StorageService)"; effective:=active]]]

wborn
wborn reviewed May 21, 2020
View reviewed changes
features/karaf/openhab-core/src/main/feature/feature.xml
@@ -39,7 +39,6 @@
<bundle>mvn:org.openhab.core.bundles/org.openhab.core.config.dispatch/${project.version}</bundle>
<bundle start-level="75">mvn:org.openhab.core.bundles/org.openhab.core.config.xml/${project.version}</bundle>
<bundle>mvn:org.openhab.core.bundles/org.openhab.core/${project.version}</bundle>
<feature dependency="true">openhab-core-storage-mapdb</feature>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using openhab-core-storage-json here instead of removing the dependency will probably fix it.

@kaikreuzer
addressed review comment
2e6fb8d 
Signed-off-by: Kai Kreuzer <kai@openhab.org>
wborn
wborn approved these changes May 22, 2020
View reviewed changes
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wborn wborn merged commit 97d7ef6 into openhab:master May 22, 2020
@kaikreuzer kaikreuzer deleted the rmmapdb branch May 22, 2020 09:10
wborn added a commit to wborn/openhab-core that referenced this pull request May 22, 2020
@wborn
Update BOMs: remove mapdb, add dagger
8022b55 
Related to openhab#1488
Fixes openhab#1238

Signed-off-by: Wouter Born <github@maindrain.net>
@wborn wborn mentioned this pull request May 22, 2020
Merged
@splatch
Copy link
Contributor

splatch commented May 22, 2020

FYI there is org.openhab.core.items.ManagedItemProvider.PersistedItemInstanceCreator which been used only by mapdb. Since mapdb is gone other thing can be removed too.

@cweitkamp
Copy link
Contributor

@splatch Thanks for the reminder. You are right. It was introduced in #1173 just to fix an issue in mapdb.

kaikreuzer pushed a commit that referenced this pull request May 22, 2020
@wborn
Update BOMs: remove mapdb, add dagger (#1493)
2b5be0b 
Related to #1488
Fixes #1238

Signed-off-by: Wouter Born <github@maindrain.net>
wborn added a commit to wborn/openhab-core that referenced this pull request May 24, 2020
@wborn
Remove openhab.tp-mapdb
b9eea85 
Related to openhab#1488, openhab#1493

Signed-off-by: Wouter Born <github@maindrain.net>
@wborn wborn mentioned this pull request May 24, 2020
Merged
@cweitkamp cweitkamp added this to the 3.0 milestone May 24, 2020
cweitkamp pushed a commit that referenced this pull request May 24, 2020
@wborn
Remove openhab.tp-mapdb (#1497)
1f4e374 
Related to #1488, #1493

Signed-off-by: Wouter Born <github@maindrain.net>
@cweitkamp cweitkamp mentioned this pull request May 27, 2020
Merged
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 11, 2023
@kaikreuzer @splatch
removed unused mapdb storage bundle (openhab#1488)
7434301 
Signed-off-by: Kai Kreuzer <kai@openhab.org>
GitOrigin-RevId: 97d7ef6
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 11, 2023
@wborn @splatch
Update BOMs: remove mapdb, add dagger (openhab#1493)
8659a53 
Related to openhab#1488
Fixes openhab#1238

Signed-off-by: Wouter Born <github@maindrain.net>
GitOrigin-RevId: 2b5be0b
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 11, 2023
@wborn @splatch
Remove openhab.tp-mapdb (openhab#1497)
2d78830 
Related to openhab#1488, openhab#1493

Signed-off-by: Wouter Born <github@maindrain.net>
GitOrigin-RevId: 1f4e374
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wborn wborn wborn approved these changes

Assignees
No one assigned
Labels
API breaking
Projects
None yet
Milestone
3.0.0.M1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kaikreuzer @wborn @splatch @cweitkamp