Fix for handling inverted cron ranges #1519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix adds support for inverted cron ranged. For example SUN-WEN. It also works all ranges and also with additional increments. Closes openhab#1516 Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
cweitkamp
approved these changes
Jun 9, 2020
Comment on lines
445
to
447
| cronExpression, chronoField, r[1], max)); | ||
|
|
||
| } |
There was a problem hiding this comment.
Would be really nice to get rid of this empty line in front of the closing bracket.
Suggested change
| cronExpression, chronoField, r[1], max)); | |
| } | |
| cronExpression, chronoField, r[1], max)); | |
| } |
Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
cweitkamp
approved these changes
Jun 9, 2020
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 11, 2023
* Fix for handling inverted cron ranges This fix adds support for inverted cron ranged. For example SUN-WEN. It also works all ranges and also with additional increments. Closes openhab#1516 Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl> GitOrigin-RevId: e84d01b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix adds support for inverted cron ranged. For example SUN-WEN.
It also works all ranges and also with additional increments.
Closes #1516
Signed-off-by: Hilbrand Bouwkamp hilbrand@h72.nl