switched PersistenceExtensions to ZonedDateTime #1588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kai Kreuzer <kai@openhab.org>
Signed-off-by: Kai Kreuzer <kai@openhab.org>
Signed-off-by: Kai Kreuzer <kai@openhab.org>
Signed-off-by: Kai Kreuzer <kai@openhab.org>
|
@openhab/core-maintainers Tests are finally green, so ready for review and hopefully soon to merge! |
wborn
reviewed
Aug 12, 2020
...re.model.script/src/org/openhab/core/model/script/scoping/ScriptImplicitlyImportedTypes.java
Show resolved
Hide resolved
|
Looks like the webui's also need to be updated for these changes @kaikreuzer. |
|
Yeah, indeed, the CometVisu seems to have issues now... |
This was referenced Aug 13, 2020
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 11, 2023
Signed-off-by: Kai Kreuzer <kai@openhab.org> GitOrigin-RevId: 3c83e8a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1451 I changed the rules from
InstanttoZonedDateTime, but I had missed thePersistenceExtensions. Fixing this, I also did some further clean up and also moved it tocore.persistenceas it does not have any dependency on the persist DSL itself.Signed-off-by: Kai Kreuzer kai@openhab.org