Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rest] fixed item links in rest api #1591

Merged
merged 1 commit into from
Aug 14, 2020
Merged

Conversation

kaikreuzer
Copy link
Member

Fixes openhab/openhab-android#2139

Signed-off-by: Kai Kreuzer kai@openhab.org

Signed-off-by: Kai Kreuzer <kai@openhab.org>
@wborn
Copy link
Member

wborn commented Aug 14, 2020

Do you know if there are more issues with the item linking?
There was also a discussion about a regression introduced by #1385.

@kaikreuzer
Copy link
Member Author

This is not at all related to item links (the openHAB concept) and thus not related to #1385.
It is about the "link" field within the REST API responses, see openhab/openhab-android#2139 for details.

@wborn
Copy link
Member

wborn commented Aug 14, 2020

Yes I understand that. When I did my most recent testing the linking appeared to be buggy but I had no time to further investigate the root cause. So I don't know if it was caused by #1385 or some other issue like this one. Therefor I postponed updating my secondary OH instance to OH3. 😉

@kaikreuzer
Copy link
Member Author

Therefor I postponed updating my secondary OH instance to OH3

This issue here is hopefully my last "major" bug that I have encountered.
It really helped my to upgrade my (one and only) production system to really have the urge to debug and fix stuff - I can highly recommend doing so and I plan to push all of you to do the same very soon, so be warned 😎 .

Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it!

@wborn wborn merged commit 8c83b60 into openhab:master Aug 14, 2020
@kaikreuzer kaikreuzer deleted the itemlinks branch August 14, 2020 10:38
@wborn
Copy link
Member

wborn commented Aug 14, 2020

I don't mind running it on my secondary instance when the linking works. But for my main instance I will first implement a WoL action (openhab/openhab-addons#3799) or I wouldn't be able to turn on my desktop PC using voice commands. 😄

@ghys
Copy link
Member

ghys commented Aug 14, 2020

I will first implement a WoL action

Cool ;) I'm using the exec binding to run wakeonlan <mac> but would definitely prefer an action ;)

@wborn wborn added this to the 3.0 milestone Aug 26, 2020
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 11, 2023
Signed-off-by: Kai Kreuzer <kai@openhab.org>
GitOrigin-RevId: 8c83b60
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Commands not working with openHAB 3
3 participants