Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build by wrapping lines #1729

Merged
merged 1 commit into from
Oct 19, 2020
Merged

Fix build by wrapping lines #1729

merged 1 commit into from
Oct 19, 2020

Conversation

wborn
Copy link
Member

@wborn wborn commented Oct 19, 2020

Caused by #1713

@wborn
Fix build by wrapping lines
6ecd442 
Caused by openhab#1713

Signed-off-by: Wouter Born <github@maindrain.net>
@wborn wborn requested a review from a team October 19, 2020 09:38
kaikreuzer
kaikreuzer approved these changes Oct 19, 2020
View reviewed changes
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, you were one minute faster than me ;-)

@kaikreuzer kaikreuzer merged commit b2c045d into openhab:master Oct 19, 2020
@wborn
Copy link
Member Author

wborn commented Oct 19, 2020

Because the Spotless XML wrapping is buggy, it will likely have a strange opinion about last minute changes. 😉
I still need to check if there is already an issue for it in the Spotless issue tracker (and create one if missing). This buggy behavior can do serious damage (openhab/openhab-addons#8413) and is a source of unnecessary work, waiting and discussions. Maybe @nedtwigg knows if there is an existing issue for this?

@wborn wborn deleted the fix-build branch October 19, 2020 09:58
@nedtwigg
Copy link

I maintain the Spotless core, but I haven't used the XML formatter myself. I see that lines are being rewrapped, but that seems like expected behavior. Is the bug that you don't want Spotless to care about line wrapping? Or is Spotless being inconsistent about it, where it passes in one place but fails in another?

@wborn
Copy link
Member Author

wborn commented Oct 21, 2020

I've created diffplug/spotless#723 for this @nedtwigg. :-)

@kaikreuzer kaikreuzer added this to the 3.0.0.M2 milestone Nov 2, 2020
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 11, 2023
@wborn @splatch
Fix build by wrapping lines (openhab#1729)
6da1368 
Caused by openhab#1713

Signed-off-by: Wouter Born <github@maindrain.net>
GitOrigin-RevId: b2c045d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaikreuzer kaikreuzer kaikreuzer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0.M2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wborn @nedtwigg @kaikreuzer