Prevent NPE on shutdown by making maps in DSLRuleProvider thread safe #1856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kai Kreuzer <kai@openhab.org>
kaikreuzer
added
the
bug
wborn
approved these changes
Nov 29, 2020
robnielsen
reviewed
Nov 29, 2020
| private final Map<String, XExpression> xExpressions = new HashMap<>(); | ||
| private final Map<String, Rule> rules = new ConcurrentHashMap<>(); | ||
| private final Map<String, IEvaluationContext> contexts = new ConcurrentHashMap<>(); | ||
| private final Map<String, XExpression> xExpressions = new ConcurrentHashMap<>(); | ||
| private int triggerId = 0; | ||
| private Set<String> markers = new HashSet<>(); |
There was a problem hiding this comment.
@kaikreuzer does markers need to be thread safe as well?
There was a problem hiding this comment.
No, afaik this method is called single threaded.
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 11, 2023
Signed-off-by: Kai Kreuzer <kai@openhab.org> GitOrigin-RevId: fe62a4f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1801
Signed-off-by: Kai Kreuzer kai@openhab.org