New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide Script Names to Script Engines #1885
Conversation
ead0362
to
c8942aa
Compare
FYI - The commit is signed off, the name just doesn't match the commit. OpenHAB requires the full name, where as the commit was not done with the full name. |
Duplicate of #1196. It looks like you also [refer a full path rather than a file name. Maybe with your input, this can finally be merged. |
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/jruby-openhab-rules-system/110598/2 |
@boc-tothefuture Is this PR still relevant? I see it has been marked as duplicate, although I am not sure if it isn't rather a further enhancement. |
Signed-off-by: Brian O'Connell <broconne@gmail.com>
Signed-off-by: Brian O'Connell <broconne@gmail.com>
0c0dfa5
to
17d475b
Compare
I have rebased this. |
Sure, fine by me. Personally I would prefer the setting to happen in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks guys!
Signed-off-by: Brian O'Connell <broconne@gmail.com> GitOrigin-RevId: 89796e7
Per the spec
I have tested this in JRuby and it works correctly.
With the ruby code:
puts __FILE__
Before the change:
<script>
After the change:
/src/openhab-scripting/tmp/openhab/conf/automation/jsr223/ruby/personal/test_1607028003.rb