Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved modbus transport from addons to core #1892

Merged
merged 5 commits into from Dec 8, 2020
Merged

Conversation

kaikreuzer
Copy link
Member

@kaikreuzer kaikreuzer commented Dec 5, 2020

addresses #1435

Maintainers, please note: I only moved the code and didn't touch it apart from the namespace change - so please refrain from review comments that concern the code itself.

Signed-off-by: Kai Kreuzer kai@openhab.org

Signed-off-by: Kai Kreuzer <kai@openhab.org>
Signed-off-by: Kai Kreuzer <kai@openhab.org>
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me and indeed the code is unchanged except for the packages/imports etc. 👍 I have one remark below:

bundles/org.openhab.core.io.transport.modbus/pom.xml Outdated Show resolved Hide resolved
Signed-off-by: Kai Kreuzer <kai@openhab.org>
Signed-off-by: Kai Kreuzer <kai@openhab.org>
Signed-off-by: Kai Kreuzer <kai@openhab.org>
@kaikreuzer kaikreuzer added rebuild Triggers the Jenkins PR build and removed rebuild Triggers the Jenkins PR build labels Dec 8, 2020
@wborn wborn added rebuild Triggers the Jenkins PR build and removed rebuild Triggers the Jenkins PR build labels Dec 8, 2020
@wborn wborn closed this Dec 8, 2020
@wborn wborn reopened this Dec 8, 2020
@kaikreuzer kaikreuzer requested a review from wborn December 8, 2020 11:48
@wborn wborn merged commit e075df3 into openhab:master Dec 8, 2020
@wborn wborn added this to the 3.0.0.RC1 milestone Dec 12, 2020
@kaikreuzer kaikreuzer added the enhancement An enhancement or new feature of the Core label Dec 14, 2020
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 11, 2023
Signed-off-by: Kai Kreuzer <kai@openhab.org>
GitOrigin-RevId: e075df3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature of the Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants