Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[automation] Correctly return the evaluation result of DSL scripts #1952

Merged
merged 1 commit into from Dec 16, 2020
Merged

[automation] Correctly return the evaluation result of DSL scripts #1952

merged 1 commit into from Dec 16, 2020

Conversation

kaikreuzer
Copy link
Member

Fixes #1946

Signed-off-by: Kai Kreuzer kai@openhab.org

@kaikreuzer
Correctly return the evaluation result of DSL scripts
19aec35 
Signed-off-by: Kai Kreuzer <kai@openhab.org>
@kaikreuzer kaikreuzer added bug An unexpected problem or unintended behavior of the Core automation labels Dec 16, 2020
@kaikreuzer kaikreuzer added this to the 3.0.0.RC2 milestone Dec 16, 2020
@kaikreuzer kaikreuzer requested a review from a team December 16, 2020 21:06
cweitkamp
cweitkamp approved these changes Dec 16, 2020
View reviewed changes
Copy link
Contributor

@cweitkamp cweitkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@cweitkamp cweitkamp merged commit 4059ea2 into openhab:master Dec 16, 2020
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/openhab-3-runs-out-of-memory-java-heap-space-errors-cpu-100-after-a-few-hours/110924/127

@morph166955 morph166955 mentioned this pull request Feb 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cweitkamp cweitkamp cweitkamp approved these changes

Assignees
No one assigned
Labels
automation bug An unexpected problem or unintended behavior of the Core
Projects
None yet
Milestone
3.0.0.RC2
Development

Successfully merging this pull request may close these issues.

Rule condition with DSL script results in error.
3 participants
@kaikreuzer @openhab-bot @cweitkamp