Extended serial port implementation #2050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: docbender <vita.tucek@seznam.cz>
kaikreuzer
approved these changes
Jan 5, 2021
There was a problem hiding this comment.
Lgtm, thanks!
I thought to vaguely remember that there was a reason for not implementing all of them - something like supporting RfC2217 ports as well, but checking the implementation, it seems that we do not have any constraint there.
@openhab/core-maintainers If I am missing anything, please scream ;-)
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 11, 2023
Signed-off-by: docbender <vita.tucek@seznam.cz> GitOrigin-RevId: 0026d89
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Serial port interface is extended by non implemented methods
Fixes #2048
Signed-off-by: Vita Tucek