Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MQTT QoS levels setting #2208

Merged
merged 1 commit into from Feb 27, 2021
Merged

Fix MQTT QoS levels setting #2208

merged 1 commit into from Feb 27, 2021

Conversation

stedon81
Copy link
Contributor

Solves issue #2145 "io transport mqtt sets wrong QoS levels to hiveMQ"
#2145

Fix is simply exchanging the enum values returned for the case 0 and case 1 branches, as they have been mixed up as compared to the mqtt specification:

According to https://www.hivemq.com/blog/mqtt-essentials-part-6-mqtt-quality-of-service-levels/, the QoS levels are:

  • At most once (0)
  • At least once (1)
  • Exactly once (2)

@stedon81 stedon81 requested a review from a team as a code owner February 18, 2021 17:54
@stedon81 stedon81 mentioned this pull request Feb 18, 2021
Closed
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/mqtt-minimum-delay-time-between-messages-that-openhab-can-process-them/114863/21

@stedon81
Copy link
Contributor Author

Will implicitly also fix issue in mqtt.homie binding:
openhab/openhab-addons#9919

@wborn
Copy link
Member

wborn commented Feb 20, 2021

I think the changes are good! Can you also sign off your commit or provide the Signed-off-by: line in a comment so we can add it? See Sign your work.

@kaikreuzer
Copy link
Member

I think we can treat that as a small patch exception and skip the DCO.

@kaikreuzer kaikreuzer changed the title io transport mqtt sets wrong QoS levels to hiveMQ #2145 Fix MQTT QoS levels setting Feb 27, 2021
@kaikreuzer kaikreuzer merged commit 361e985 into openhab:main Feb 27, 2021
@kaikreuzer kaikreuzer added this to the 3.1 milestone Feb 27, 2021
@kaikreuzer kaikreuzer added the bug An unexpected problem or unintended behavior of the Core label Feb 27, 2021
@kaikreuzer kaikreuzer mentioned this pull request Feb 27, 2021
Closed
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/irobot-9xx-on-openhab/17774/239

@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/irobot-9xx-on-openhab/17774/258

@falkena falkena mentioned this pull request Apr 26, 2021
Closed
@rimago rimago mentioned this pull request Jun 13, 2021
Merged
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 11, 2023
@stedon81 @splatch
io transport mqtt sets wrong QoS levels to hiveMQ openhab#2145 (openh…
6af3d4f 
…ab#2208)

Signed-off-by: Stefan Donath <donath.stefan@mail.donath-productions.ipactive.de>
GitOrigin-RevId: 361e985
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaikreuzer kaikreuzer kaikreuzer approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of the Core
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@stedon81 @openhab-bot @wborn @kaikreuzer