Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement hostnameValidated flag for secure MQTT connections #2348

Merged
merged 2 commits into from May 10, 2021

Conversation

mherwege
Copy link
Contributor

@mherwege mherwege commented May 6, 2021

Solves #2346

Implementation of a flag to be able to switch off hostname verification in the mqtt transport. The latest release of hivemq does hostname verification by default (none was done before). This flag allows this to be switched off through the transport, so bindings relying on the transport are able to disable hostname verification if required.

Signed-off-by: Mark Herwege mark.herwege@telenet.be

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
@mherwege mherwege requested a review from a team as a code owner May 6, 2021 15:33
@cweitkamp cweitkamp added the enhancement An enhancement or new feature of the Core label May 6, 2021
@cweitkamp cweitkamp linked an issue May 6, 2021 that may be closed by this pull request
@wborn wborn added awaiting other PR Depends on another PR and removed awaiting other PR Depends on another PR labels May 6, 2021
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this configuration option. The code looks good but I think the config param needs a few tweaks.

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wborn wborn merged commit 527f2c3 into openhab:main May 10, 2021
@wborn wborn added this to the 3.1 milestone May 10, 2021
fwolter pushed a commit to fwolter/openhab-core that referenced this pull request May 24, 2021
…#2348)

Fixes openhab#2346

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
@mherwege mherwege deleted the mqtt_hostname_validation branch March 7, 2023 09:24
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 11, 2023
…#2348)

Fixes openhab#2346

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
GitOrigin-RevId: 527f2c3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature of the Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make hostname verification configurable in MQTT transport
3 participants