Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add chart theme with transparent background #2415

Closed
wants to merge 1 commit into from
Closed

Add chart theme with transparent background #2415

wants to merge 1 commit into from

Conversation

mueller-ma
Copy link
Member

Currently the background of the dark theme differs from the background
color of the Android app. With a transparent background, it'll be the
same.
The version bump is required so the app can use the current dark theme
for older versions of the server.

Closes #1183

PS: AFAIK this is my first PR here and I'm still having issues setting up my IDE. The build doesn't work for me locally, so I want to see if the CI here passes.

@mueller-ma
Add chart theme with transparent background
81ce0f4 
Currently the background of the dark theme differs from the background
color of the Android app. With a transparent background, it'll be the
same.
The version bump is required so the app can use the current `dark` theme
for older versions of the server.

Closes openhab#1183
@mueller-ma
Copy link
Member Author

I cannot see the issue in the log: https://ci.openhab.org/job/PR-openHAB-Core/3598/org.openhab.core.bundles$org.openhab.core.ui/console

cweitkamp
cweitkamp reviewed Jun 29, 2021
View reviewed changes
.../java/org/openhab/core/ui/internal/chart/defaultchartprovider/ChartThemeDarkTransparent.java

/**
* Implementation of the dark {@link ChartTheme chart theme} with transparent background.
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

[ERROR] org.openhab.core.ui.internal.chart.defaultchartprovider.ChartThemeDarkTransparent.java:[20]
An author tag is missing

@mueller-ma
Copy link
Member Author

Locally I get the following error (IntelliJ Idea with built-in mvn and -DskipTests=true -DskipChecks=true install):

0    [org.eclipse.emf.mwe2.launch.runtime.Mwe2Launcher.main()] ERROR mf.mwe2.launch.runtime.Mwe2Launcher  - Error traversing archive C:\Program Files\JetBrains\IntelliJ IDEA Community Edition 2021.1.2\plugins\maven\lib\maven3\boot\plexus-classworlds.license
org.eclipse.emf.common.util.WrappedException: Error traversing archive C:\Program Files\JetBrains\IntelliJ IDEA Community Edition 2021.1.2\plugins\maven\lib\maven3\boot\plexus-classworlds.license
	at org.eclipse.xtext.mwe.PathTraverser.traverseArchive(PathTraverser.java:73)
	at org.eclipse.xtext.mwe.PathTraverser.findAllResourceUris(PathTraverser.java:50)
	at org.eclipse.xtext.mwe.PathTraverser.resolvePathes(PathTraverser.java:36)
	at org.eclipse.xtext.mwe.RuntimeResourceSetInitializer.getPathToUriMap(RuntimeResourceSetInitializer.java:55)
	at org.eclipse.xtext.mwe.RuntimeResourceSetInitializer.getInitializedResourceSet(RuntimeResourceSetInitializer.java:74)
	at org.eclipse.emf.mwe2.launch.runtime.Mwe2Runner.getConfiguredResourceSet(Mwe2Runner.java:132)
	at org.eclipse.emf.mwe2.launch.runtime.Mwe2Runner.run(Mwe2Runner.java:57)
	at org.eclipse.emf.mwe2.launch.runtime.Mwe2Runner.run(Mwe2Runner.java:53)
	at org.eclipse.emf.mwe2.launch.runtime.Mwe2Launcher.run(Mwe2Launcher.java:79)
	at org.eclipse.emf.mwe2.launch.runtime.Mwe2Launcher.main(Mwe2Launcher.java:37)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at org.codehaus.mojo.exec.ExecJavaMojo$1.run(ExecJavaMojo.java:293)
	at java.base/java.lang.Thread.run(Thread.java:834)
Caused by: java.util.zip.ZipException: zip END header not found
	at java.base/java.util.zip.ZipFile$Source.zerror(ZipFile.java:1529)
	at java.base/java.util.zip.ZipFile$Source.findEND(ZipFile.java:1430)
	at java.base/java.util.zip.ZipFile$Source.initCEN(ZipFile.java:1437)
	at java.base/java.util.zip.ZipFile$Source.<init>(ZipFile.java:1268)
	at java.base/java.util.zip.ZipFile$Source.get(ZipFile.java:1231)
	at java.base/java.util.zip.ZipFile$CleanableResource.<init>(ZipFile.java:726)
	at java.base/java.util.zip.ZipFile$CleanableResource.get(ZipFile.java:843)
	at java.base/java.util.zip.ZipFile.<init>(ZipFile.java:246)
	at java.base/java.util.zip.ZipFile.<init>(ZipFile.java:176)
	at java.base/java.util.zip.ZipFile.<init>(ZipFile.java:190)
	at org.eclipse.xtext.mwe.PathTraverser.traverseArchive(PathTraverser.java:58)
	... 15 more

Process finished with exit code 1

@kaikreuzer
Copy link
Member

Sounds like a problem with your IntelliJ, if it cannot parse the license file...
Can't you run a plain mvn build from CLI?

@cweitkamp cweitkamp added the UI User Interface label Jul 21, 2021
@mueller-ma
Copy link
Member Author

Short update: Using official Maven with Zulu Java 11 I can build the project, but I still have to read the docs on how to run openHAB.

@mueller-ma
Copy link
Member Author

I posted my current issue with this PR in the forum, but didn't receive an answer so far: https://community.openhab.org/t/basic-authentication-configured-when-running-oh-via-eclipse/125378

wborn added a commit to wborn/openhab-core that referenced this pull request Oct 2, 2021
@wborn
ChartServlet bug fixes and improvements
b04758c 
* Improve exception handling
* Add dark_transparent theme
* Add null annotations
* Use java.time classes instead of Date and magic numbers
* Upgrade XChart to 3.1.0

For XChart release notes see:

https://knowm.org/open-source/xchart/xchart-change-log/

On newer XChart versions there is an issue when using customized grid lines:

knowm/XChart#628

Fixes openhab#1183
Related to openhab#2501
Supersedes openhab#2415

Signed-off-by: Wouter Born <github@maindrain.net>
@wborn wborn mentioned this pull request Oct 2, 2021
Merged
wborn added a commit to wborn/openhab-core that referenced this pull request Oct 3, 2021
@wborn
ChartServlet bug fixes and improvements
9b678c4 
* Improve exception handling
* Add themes
* Add null annotations
* Use java.time classes instead of Date and magic numbers
* Upgrade XChart to 3.1.0

For XChart release notes see:

https://knowm.org/open-source/xchart/xchart-change-log/

On newer XChart versions there is an issue when using customized grid lines:

knowm/XChart#628

Fixes openhab#1183
Related to openhab#2501
Supersedes openhab#2415

Signed-off-by: Wouter Born <github@maindrain.net>
wborn added a commit to wborn/openhab-core that referenced this pull request Oct 3, 2021
@wborn
ChartServlet bug fixes and improvements
504e81a 
* Improve exception handling
* Add transparent themes
* Add null annotations
* Use java.time classes instead of Date and magic numbers
* Upgrade XChart to 3.1.0

For XChart release notes see:

https://knowm.org/open-source/xchart/xchart-change-log/

On newer XChart versions there is an issue when using customized grid lines:

knowm/XChart#628

Fixes openhab#1183
Related to openhab#2501
Supersedes openhab#2415

Signed-off-by: Wouter Born <github@maindrain.net>
wborn added a commit to wborn/openhab-core that referenced this pull request Oct 3, 2021
@wborn
ChartServlet bug fixes and improvements
21bf485 
* Improve exception handling
* Add transparent themes
* Add null annotations
* Use java.time classes instead of Date and magic numbers
* Upgrade XChart to 3.1.0
* Fix buggy legend position logic:
  Reinitialize counter to 0. So it does not work on legend position counter values of previously created charts.
  Use a local variable for the position counter instead of a field. This prevents issues when creating multiple charts simultanuously.

For XChart release notes see:

https://knowm.org/open-source/xchart/xchart-change-log/

On newer XChart versions there is an issue when using customized grid lines:

knowm/XChart#628

Fixes openhab#1183
Related to openhab#2501
Supersedes openhab#2415

Signed-off-by: Wouter Born <github@maindrain.net>
wborn added a commit to wborn/openhab-core that referenced this pull request Oct 4, 2021
@wborn
ChartServlet bug fixes and improvements
8fa2b1e 
* Improve exception handling
* Add transparent themes
* Add null annotations
* Use java.time classes instead of Date and magic numbers
* Upgrade XChart to 3.1.0
* Fix buggy legend position logic:
  Reinitialize counter to 0. So it does not work on legend position counter values of previously created charts.
  Use a local variable for the position counter instead of a field. This prevents issues when creating multiple charts simultanuously.

For XChart release notes see:

https://knowm.org/open-source/xchart/xchart-change-log/

On newer XChart versions there is an issue when using customized grid lines:

knowm/XChart#628

Fixes openhab#1183
Related to openhab#2501
Supersedes openhab#2415

Signed-off-by: Wouter Born <github@maindrain.net>
wborn added a commit to wborn/openhab-core that referenced this pull request Oct 4, 2021
@wborn
ChartServlet bug fixes and improvements
c0ad308 
* Improve exception handling
* Add transparent themes
* Add null annotations
* Use java.time classes instead of Date and magic numbers
* Upgrade XChart to 3.1.0
* Fix buggy legend position logic:
  Reinitialize counter to 0. So it does not work on legend position counter values of previously created charts.
  Use a local variable for the position counter instead of a field. This prevents issues when creating multiple charts simultanuously.

For XChart release notes see:

https://knowm.org/open-source/xchart/xchart-change-log/

On newer XChart versions there is an issue when using customized grid lines:

knowm/XChart#628

Fixes openhab#1183
Related to openhab#2501
Supersedes openhab#2415

Signed-off-by: Wouter Born <github@maindrain.net>
wborn added a commit to wborn/openhab-core that referenced this pull request Oct 4, 2021
@wborn
ChartServlet bug fixes and improvements
5638eda 
* Improve exception handling
* Add transparent themes
* Add null annotations
* Use java.time classes instead of Date and magic numbers
* Upgrade XChart to 3.1.0
* Fix buggy legend position logic:
  Reinitialize counter to 0. So it does not work on legend position counter values of previously created charts.
  Use a local variable for the position counter instead of a field. This prevents issues when creating multiple charts simultanuously.

For XChart release notes see:

https://knowm.org/open-source/xchart/xchart-change-log/

On newer XChart versions there is an issue when using customized grid lines:

knowm/XChart#628

Fixes openhab#1183
Related to openhab#2501
Supersedes openhab#2415

Signed-off-by: Wouter Born <github@maindrain.net>
wborn added a commit to wborn/openhab-core that referenced this pull request Oct 4, 2021
@wborn
ChartServlet bug fixes and improvements
4d951a5 
* Improve exception handling
* Add transparent themes
* Add null annotations
* Use java.time classes instead of Date and magic numbers
* Upgrade XChart to 3.1.0
* Fix buggy legend position logic:
  Reinitialize counter to 0. So it does not work on legend position counter values of previously created charts.
  Use a local variable for the position counter instead of a field. This prevents issues when creating multiple charts simultanuously.

For XChart release notes see:

https://knowm.org/open-source/xchart/xchart-change-log/

On newer XChart versions there is an issue when using customized grid lines:

knowm/XChart#628

Fixes openhab#1183
Related to openhab#2501
Supersedes openhab#2415

Signed-off-by: Wouter Born <github@maindrain.net>
kaikreuzer pushed a commit that referenced this pull request Oct 9, 2021
@wborn
ChartServlet bug fixes and improvements (#2502)
ac84206 
* Improve exception handling
* Add transparent themes
* Add null annotations
* Use java.time classes instead of Date and magic numbers
* Upgrade XChart to 3.1.0
* Fix buggy legend position logic:
  Reinitialize counter to 0. So it does not work on legend position counter values of previously created charts.
  Use a local variable for the position counter instead of a field. This prevents issues when creating multiple charts simultanuously.

For XChart release notes see:

https://knowm.org/open-source/xchart/xchart-change-log/

On newer XChart versions there is an issue when using customized grid lines:

knowm/XChart#628

Fixes #1183
Related to #2501
Supersedes #2415

Signed-off-by: Wouter Born <github@maindrain.net>
@kaikreuzer
Copy link
Member

This has been included in #2502.

@kaikreuzer kaikreuzer closed this Oct 9, 2021
@mueller-ma mueller-ma deleted the 1183-chart-transparent-bg branch October 10, 2021 12:15
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 12, 2023
@wborn @splatch
ChartServlet bug fixes and improvements (openhab#2502)
7e5be2c 
* Improve exception handling
* Add transparent themes
* Add null annotations
* Use java.time classes instead of Date and magic numbers
* Upgrade XChart to 3.1.0
* Fix buggy legend position logic:
  Reinitialize counter to 0. So it does not work on legend position counter values of previously created charts.
  Use a local variable for the position counter instead of a field. This prevents issues when creating multiple charts simultanuously.

For XChart release notes see:

https://knowm.org/open-source/xchart/xchart-change-log/

On newer XChart versions there is an issue when using customized grid lines:

knowm/XChart#628

Fixes openhab#1183
Related to openhab#2501
Supersedes openhab#2415

Signed-off-by: Wouter Born <github@maindrain.net>
GitOrigin-RevId: ac84206
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cweitkamp cweitkamp cweitkamp left review comments

Assignees
No one assigned
Labels
UI User Interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Charts with transparent background
3 participants
@mueller-ma @kaikreuzer @cweitkamp