Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a system setting to define how to sort group members #2417

Merged
merged 3 commits into from
Jun 26, 2021
Merged

Add a system setting to define how to sort group members #2417

merged 3 commits into from
Jun 26, 2021

Conversation

lolodomo
Copy link
Contributor

Related to #2123

Signed-off-by: Laurent Garnier lg.hc@free.fr

@lolodomo lolodomo requested a review from a team as a code owner June 26, 2021 13:20
@lolodomo
Copy link
Contributor Author

@cweitkamp for review.

Once merged, I will add this setting in the distribution runtime.cfg in comment.

@lolodomo
Copy link
Contributor Author

lolodomo commented Jun 26, 2021 •
edited
Loading

@kaikreuzer : ideally I would include this PR in 3.1. If not, users will discover a new sort of group members in sitemap without any option to restore the behavior we had in 2.x and 3.0 (which takes into account the sort of items defined by the user in its item file)

@lolodomo
Add a system setting to define how to sort group members
db234b4 
Related to openhab#2123

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
kaikreuzer
kaikreuzer requested changes Jun 26, 2021
View reviewed changes
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that this is a regression that we should fix for 3.1.
I would even be more aggressive than your suggestion and define the 2.5/3.0 behavior as the default and the new sorting options as a feature that can be enabled, if wished. Wdyt?

bundles/org.openhab.core.ui/src/main/resources/OH-INF/config/sitemap.xml Outdated Show resolved Hide resolved
bundles/org.openhab.core.ui/src/main/resources/OH-INF/config/sitemap.xml Outdated Show resolved Hide resolved
bundles/org.openhab.core.ui/src/main/resources/OH-INF/config/sitemap.xml Outdated Show resolved Hide resolved
@ghys
Copy link
Member

ghys commented Jun 26, 2021

A suggestion, perhaps for later, would be to also consider the value of the widgetOrder metadata that the main UI knows and allows to edit, it was mainly defined for itself but it's not limited to it, it could very well be used by sitemaps too. See #2123 (comment)

Screenshot_20210626_203311

@kaikreuzer
Copy link
Member

@ghys Sounds like a good enhancement of this PR for 3.2 :-).

@lolodomo
Copy link
Contributor Author

@ghys Sounds like a good enhancement of this PR for 3.2 :-).

Too late for that for 3.1 and that is probably not so easy as the current change.

@lolodomo
Copy link
Contributor Author

I agree that this is a regression that we should fix for 3.1.
I would even be more aggressive than your suggestion and define the 2.5/3.0 behavior as the default and the new sorting options as a feature that can be enabled, if wished. Wdyt?

I fully agree with you, NONE is now the default.

@lolodomo
Review comments considered
6934f92 
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@lolodomo
Review comment: set NONE as default value
b31a73c 
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
kaikreuzer
kaikreuzer approved these changes Jun 26, 2021
View reviewed changes
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, many thanks!

@kaikreuzer kaikreuzer merged commit 3f102c5 into openhab:main Jun 26, 2021
@kaikreuzer kaikreuzer added the bug An unexpected problem or unintended behavior of the Core label Jun 26, 2021
@kaikreuzer kaikreuzer added this to the 3.1 milestone Jun 26, 2021
@kaikreuzer kaikreuzer added enhancement An enhancement or new feature of the Core and removed bug An unexpected problem or unintended behavior of the Core labels Jun 26, 2021
@lolodomo lolodomo deleted the groupsortsetting branch June 26, 2021 20:46
@lolodomo
Copy link
Contributor Author

@kaikreuzer : do you think we should "show" this new setting in the default runtime.cfg file, helping users to change it from configuration files ?

@kaikreuzer
Copy link
Member

Would make sense yes. I can merge a distro PR, if you'd create it.

@lolodomo lolodomo mentioned this pull request Aug 25, 2021
Closed
ghys pushed a commit to ghys/openhab-core that referenced this pull request Sep 9, 2021
@lolodomo @ghys
Add a system setting to define how to sort group members (openhab#2417)
faba2ee 
* Add a system setting to define how to sort group members

Related to openhab#2123

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 11, 2023
@lolodomo @splatch
Add a system setting to define how to sort group members (openhab#2417)
ece1945 
* Add a system setting to define how to sort group members

Related to openhab#2123

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
GitOrigin-RevId: 3f102c5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaikreuzer kaikreuzer kaikreuzer approved these changes

Assignees
No one assigned
Labels
enhancement An enhancement or new feature of the Core
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lolodomo @ghys @kaikreuzer