Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add semantics to default system channel types #2428

Merged
merged 2 commits into from
Jul 19, 2021
Merged

Add semantics to default system channel types #2428

merged 2 commits into from
Jul 19, 2021

Conversation

lolodomo
Copy link
Contributor

Fix #2427

Signed-off-by: Laurent Garnier lg.hc@free.fr

@lolodomo
Add semantics to default system channel types
3bed0e8 
Fix openhab#2427

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@lolodomo lolodomo requested a review from a team as a code owner July 10, 2021 13:50
cweitkamp
cweitkamp reviewed Jul 11, 2021
View reviewed changes
Copy link
Contributor

@cweitkamp cweitkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding tags to the system default channel types. I guess one is allowed to change them when adding equipment or links via UI. Some users might not like our suggested semantic model.

I left some remarks for discussion.

...penhab.core.thing/src/main/java/org/openhab/core/thing/DefaultSystemChannelTypeProvider.java Outdated Show resolved Hide resolved
...penhab.core.thing/src/main/java/org/openhab/core/thing/DefaultSystemChannelTypeProvider.java Outdated Show resolved Hide resolved
...penhab.core.thing/src/main/java/org/openhab/core/thing/DefaultSystemChannelTypeProvider.java Outdated Show resolved Hide resolved
...penhab.core.thing/src/main/java/org/openhab/core/thing/DefaultSystemChannelTypeProvider.java Outdated Show resolved Hide resolved
@cweitkamp cweitkamp added the enhancement An enhancement or new feature of the Core label Jul 11, 2021
@lolodomo
Copy link
Contributor Author

lolodomo commented Jul 11, 2021 •
edited
Loading

Thanks for adding tags to the system default channel types. I guess one is allowed to change them when adding equipment or links via UI. Some users might not like our suggested semantic model.

Yes of course, this is defaults and the user can select what he likes in UI if he does not like the defaults.

@lolodomo
Review comments handled
7393e03 
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@cweitkamp cweitkamp added this to the 3.2 milestone Jul 19, 2021
cweitkamp
cweitkamp approved these changes Jul 19, 2021
View reviewed changes
Copy link
Contributor

@cweitkamp cweitkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@cweitkamp cweitkamp merged commit e5e62d1 into openhab:main Jul 19, 2021
@lolodomo lolodomo deleted the semantics_system_channels branch July 19, 2021 12:41
ghys pushed a commit to ghys/openhab-core that referenced this pull request Sep 9, 2021
@lolodomo @ghys
[semantics] Add semantics to default system channel types (openhab#2428)
c5506d9 
* Add semantics to default system channel types

Fix openhab#2427

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 11, 2023
@lolodomo @splatch
[semantics] Add semantics to default system channel types (openhab#2428)
a9be1f2 
* Add semantics to default system channel types

Fix openhab#2427

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
GitOrigin-RevId: e5e62d1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cweitkamp cweitkamp cweitkamp approved these changes

Assignees
No one assigned
Labels
enhancement An enhancement or new feature of the Core
Projects
None yet
Milestone
3.2
Development

Successfully merging this pull request may close these issues.

Adding semantics tags to system channels
2 participants
@lolodomo @cweitkamp