Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent ordering of entries in jsondb #2437

Merged
merged 5 commits into from
Aug 8, 2021

Conversation

ssalonen
Copy link
Contributor

Resolves #2436.

Signed-off-by: Sami Salonen ssalonen@gmail.com

Resolves openhab#2436.

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
@ssalonen ssalonen requested a review from a team as a code owner July 23, 2021 10:37
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/storing-configuration-userdata-in-git/124727/7

@ssalonen ssalonen changed the title Consistent ordering of entries in jsondb WIP: Consistent ordering of entries in jsondb Jul 24, 2021
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
@ssalonen ssalonen changed the title WIP: Consistent ordering of entries in jsondb Consistent ordering of entries in jsondb Jul 25, 2021
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
@kaikreuzer kaikreuzer added rebuild Triggers the Jenkins PR build enhancement An enhancement or new feature of the Core and removed rebuild Triggers the Jenkins PR build labels Jul 26, 2021
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ssalonen, this looks good to me and the change makes sense in order to allow a proper diffing of changes in those files.

@kaikreuzer kaikreuzer merged commit 4bcf486 into openhab:main Aug 8, 2021
@kaikreuzer kaikreuzer added this to the 3.2 milestone Aug 8, 2021
ghys pushed a commit to ghys/openhab-core that referenced this pull request Sep 9, 2021
* Consistent ordering of entries in jsondb

Resolves openhab#2436.

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 11, 2023
* Consistent ordering of entries in jsondb

Resolves openhab#2436.

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
GitOrigin-RevId: 4bcf486
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature of the Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consistent ordering of entries in jsondb to ensure minimal delta
3 participants