Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[automation] implement a listener for ScriptEngineFactory changes #2459

Merged
merged 2 commits into from
Aug 22, 2021

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented Aug 17, 2021

Fixes #2458

This is a different approach than the one proposed in the issue which implements a cleaner solution.

Signed-off-by: Jan N. Klug jan.n.klug@rub.de

Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
@J-N-K J-N-K requested a review from a team as a code owner August 17, 2021 18:02
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
@kaikreuzer
Copy link
Member

PR build failed due to spotless checks.

@J-N-K
Copy link
Member Author

J-N-K commented Aug 19, 2021

Oops. Already fixed that but forgot to push...

Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks.

@kaikreuzer kaikreuzer merged commit b02dfdc into openhab:main Aug 22, 2021
@kaikreuzer kaikreuzer added the enhancement An enhancement or new feature of the Core label Aug 22, 2021
@kaikreuzer kaikreuzer added this to the 3.2 milestone Aug 22, 2021
@J-N-K J-N-K deleted the scriptenginefactorylistener branch August 22, 2021 10:19
ghys pushed a commit to ghys/openhab-core that referenced this pull request Sep 9, 2021
…enhab#2459)

* implement a listener for ScriptEngineFactory changes

Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/openhab-3-2-milestone-discussion/125097/48

splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 11, 2023
…enhab#2459)

* implement a listener for ScriptEngineFactory changes

Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
GitOrigin-RevId: b02dfdc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature of the Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[automation] Scripts should be unloaded when the ScriptEngineFactory becomes unavailable
3 participants