[monitor] Import javax.management package to correctly register GC metrics #2484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kai Kreuzer <kai@openhab.org>
kaikreuzer
added
the
bug
|
Thanks, I tested the fix successfully. Were you able to reproduce it or were I the only one who encountered this bug? |
|
@fwolter I experienced the logged error from your workaround in my IDE setup, so that helped me to quickly reproduce and fix it. |
wborn
added a commit
to wborn/openhab-core
that referenced
this pull request
Feb 15, 2022
Looks like this workaround introduced in openhab#2480 is unnecessary nowadays because openhab#2484 addressed the root cause. This fixes the AvoidCatchingThrowable SAT findings. Signed-off-by: Wouter Born <github@maindrain.net>
cweitkamp
pushed a commit
that referenced
this pull request
Feb 15, 2022
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 12, 2023
Looks like this workaround introduced in openhab#2480 is unnecessary nowadays because openhab#2484 addressed the root cause. This fixes the AvoidCatchingThrowable SAT findings. Signed-off-by: Wouter Born <github@maindrain.net> GitOrigin-RevId: 69c6370
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2389
Signed-off-by: Kai Kreuzer kai@openhab.org