Configure default timeout of 15 minutes for all testable and lifecycle methods #2550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e methods This helps to identify what tests cause builds to fail and it will more quickly end builds. For instance the WebClientFactoryImplTest currently often hangs on my local builds. With this configuration in place it is easy to see and it will timeout after 15 minutes: [ERROR] Tests run: 5, Failures: 0, Errors: 1, Skipped: 4, Time elapsed: 900.207 s <<< FAILURE! - in org.openhab.core.io.net.http.internal.WebClientFactoryImplTest [ERROR] org.openhab.core.io.net.http.internal.WebClientFactoryImplTest.testGetClients Time elapsed: 900.194 s <<< ERROR! java.util.concurrent.TimeoutException: tearDown() timed out after 15 minutes See: https://junit.org/junit5/docs/current/user-guide/#writing-tests-declarative-timeouts Signed-off-by: Wouter Born <github@maindrain.net>
cweitkamp
approved these changes
Oct 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps to identify what tests cause builds to fail and it will more quickly end builds.
For instance the
WebClientFactoryImplTestcurrently often hangs on my local builds.With this configuration in place it is easy to see and it will timeout after 15 minutes:
See: https://junit.org/junit5/docs/current/user-guide/#writing-tests-declarative-timeouts