[automation] Change LifecycleScriptExtensionProvider and its Disposable interface to be public #2565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimtng
force-pushed
the
lifecycletracker-scope
branch
2 times, most recently
from
4460ef6
to
276fa54
Compare
…blic Signed-off-by: Jimmy Tanagra <jimmy@tanagra.id.au>
jimtng
force-pushed
the
lifecycletracker-scope
branch
from
276fa54
to
da6402f
Compare
cweitkamp
added
automation
enhancement
cweitkamp
changed the title
cweitkamp
changed the title
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 12, 2023
… interface public (openhab#2565) Signed-off-by: Jimmy Tanagra <jimmy@tanagra.id.au> GitOrigin-RevId: 5d5b766
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LifecycleScriptExtensionProvider's Disposable interface is package-private which caused scriptry engines, e.g. JRuby unable to create a hook needed by the LifecycleTracker.addDisposeHook(). The hook is implemented from the
Disposablefunctional interface which was not public.Just making Disposable public without moving LifecycleScriptExtensionProvide out of the internal package wasn't enough.
Resolve #2287
See boc-tothefuture/openhab-jruby#366