Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test failures when building with Java 17 #2788

Merged
merged 1 commit into from
Feb 20, 2022
Merged

Fix test failures when building with Java 17 #2788

merged 1 commit into from
Feb 20, 2022

Conversation

wborn
Copy link
Member

@wborn wborn commented Feb 20, 2022

  • Adds some --add-opens to maven-surefire-plugin for:
    • modbus transport tests (java.net)
    • tests using Gson/XStream (java.util)
  • Only run ScriptScopeOSGiTest when Nashorn is available as it has been removed since JDK 15

@wborn
Fix test failures when building with Java 17
f807c4e 
* Adds some --add-opens to maven-surefire-plugin for:
  * modbus transport tests (java.net)
  * tests using Gson/XStream (java.util)
* Only run ScriptScopeOSGiTest when Nashorn is available as it has been removed since JDK 15

Signed-off-by: Wouter Born <github@maindrain.net>
@wborn wborn added the test label Feb 20, 2022
@wborn wborn requested a review from a team as a code owner February 20, 2022 11:31
@wborn wborn mentioned this pull request Feb 20, 2022
Closed
9 tasks
kaikreuzer
kaikreuzer approved these changes Feb 20, 2022
View reviewed changes
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kaikreuzer kaikreuzer added this to the 3.3 milestone Feb 20, 2022
@kaikreuzer kaikreuzer merged commit 5e33cfc into openhab:main Feb 20, 2022
@wborn wborn deleted the java17-tests branch February 20, 2022 19:40
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 12, 2023
@wborn @splatch
Fix test failures when building with Java 17 (openhab#2788)
b107c8f 
* Adds some --add-opens to maven-surefire-plugin for:
  * modbus transport tests (java.net)
  * tests using Gson/XStream (java.util)
* Only run ScriptScopeOSGiTest when Nashorn is available as it has been removed since JDK 15

Signed-off-by: Wouter Born <github@maindrain.net>
GitOrigin-RevId: 5e33cfc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaikreuzer kaikreuzer kaikreuzer approved these changes

Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wborn @kaikreuzer