Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "recursive membership detected" for plain items #2918

Merged
merged 2 commits into from
Apr 24, 2022

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented Apr 16, 2022

Fixes #2916

Plain items can't have Childs and therefore should not be considered when calculating parents/childs of a group.

Signed-off-by: Jan N. Klug github@klug.nrw

@J-N-K J-N-K requested a review from a team as a code owner April 16, 2022 15:09
@J-N-K J-N-K closed this Apr 16, 2022
@J-N-K J-N-K reopened this Apr 16, 2022
Signed-off-by: Jan N. Klug <github@klug.nrw>
Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K J-N-K force-pushed the bug-fixrecursivemembershipdetection branch from c8763ed to 8774483 Compare April 20, 2022 17:40
@wborn wborn added the bug An unexpected problem or unintended behavior of the Core label Apr 22, 2022
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@wborn wborn merged commit a42e798 into openhab:main Apr 24, 2022
@wborn wborn added this to the 3.3 milestone Apr 24, 2022
@J-N-K J-N-K deleted the bug-fixrecursivemembershipdetection branch April 24, 2022 12:39
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/recursive-group-membership-found/135192/13

splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 12, 2023
Signed-off-by: Jan N. Klug <github@klug.nrw>
GitOrigin-RevId: a42e798
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of the Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recursive group membership found on an item
3 participants