Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Californium to 2.7.3 #3085

Merged
merged 1 commit into from Sep 21, 2022
Merged

Conversation

wborn
Copy link
Member

@wborn wborn commented Sep 18, 2022

Upgrades Californium from 2.0.0 to 2.7.3 which has many fixes.

For release notes see:

Replaces #3061, #3062


Feature verification only succeeds when using the Eclipse Orbit version of net.i2p.crypto.eddsa.
So net.i2p.crypto.eddsa_0.3.0.v20220506-1020.jar needs to be added to the OH Maven Repo before CI will succceed.

Upgrades Californium from 2.0.0 to 2.7.3 which has many fixes.

For release notes see:

* https://projects.eclipse.org/projects/iot.californium/governance

Replaces openhab#3061, openhab#3062

Signed-off-by: Wouter Born <github@maindrain.net>
@J-N-K
Copy link
Member

J-N-K commented Sep 18, 2022

Thanks for looking into this. I also tried and ran into a ton of issues.

@wborn
Copy link
Member Author

wborn commented Sep 18, 2022

I don't have any Shelly or Tradfri devices so I hope somebody who does can check if it all keeps working properly. 😉

To build this locally first get and install the Orbit bundle in your local Maven repo like this:

wget https://download.eclipse.org/releases/2022-06/202206151000/plugins/net.i2p.crypto.eddsa_0.3.0.v20220506-1020.jar
mvn install:install-file -Dfile=./net.i2p.crypto.eddsa_0.3.0.v20220506-1020.jar -DgroupId=org.eclipse.orbit.bundles -DartifactId=net.i2p.crypto.eddsa -Dversion=0.3.0.v20220506-1020 -Dpackaging=jar

@kaikreuzer kaikreuzer added rebuild Triggers the Jenkins PR build and removed rebuild Triggers the Jenkins PR build labels Sep 20, 2022
@kaikreuzer kaikreuzer merged commit 149a9e9 into openhab:main Sep 21, 2022
@kaikreuzer kaikreuzer added this to the 3.4 milestone Sep 21, 2022
@wborn wborn deleted the californium-2.7.3 branch September 21, 2022 06:39
@jlaur
Copy link
Contributor

jlaur commented Sep 22, 2022

@wborn - I'm seeing this now when compiling org.openhab.persistence.jdbc, can you advise how to fix it?

[WARNING] The POM for org.eclipse.orbit.bundles:net.i2p.crypto.eddsa:jar:0.3.0.v20220506-1020 is missing, no dependency information available

@wborn
Copy link
Member Author

wborn commented Sep 22, 2022

can you advise how to fix it?

We craft our own POM and then ask Kai to upload it to the OH Maven Repo and the warnings will stop.

Something like this will do:

<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
    <modelVersion>4.0.0</modelVersion>

    <groupId>org.eclipse.orbit.bundles</groupId>
    <artifactId>net.i2p.crypto.eddsa</artifactId>
    <version>0.3.0.v20220506-1020</version>
    <name>EdDSA-Java</name>

    <description>Implementation of EdDSA in Java</description>

    <url>https://github.com/str4d/ed25519-java</url>

    <licenses>
        <license>
            <name>CC0 1.0 Universal</name>
            <url>https://creativecommons.org/publicdomain/zero/1.0/</url>
            <distribution>repo</distribution>
        </license>
    </licenses>

</project>

There are similar issues for some add-on dependencies, see: openhab/openhab-addons#11524

@kaikreuzer
Copy link
Member

I've uploaded it. But we indeed never have poms in our repo, so you will see similar warnings all over the place.

@jlaur
Copy link
Contributor

jlaur commented Sep 23, 2022

@wborn, @kaikreuzer - right, I missed that now it seems all add-ons generates the mentioned warning, not only persistence.jdbc. This specific problem is new though.

@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/shelly-binding/56862/2791

@wborn wborn removed the enhancement An enhancement or new feature of the Core label Dec 17, 2022
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 12, 2023
Upgrades Californium from 2.0.0 to 2.7.3 which has many fixes.

For release notes see:

* https://projects.eclipse.org/projects/iot.californium/governance

Replaces openhab#3061, openhab#3062

Signed-off-by: Wouter Born <github@maindrain.net>
GitOrigin-RevId: 149a9e9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants