Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix StartLevelService "hanging" if config is changed. #3092

Merged
merged 1 commit into from Sep 25, 2022
Merged

Fix StartLevelService "hanging" if config is changed. #3092

merged 1 commit into from Sep 25, 2022

Conversation

ccutrer
Copy link
Contributor

@ccutrer ccutrer commented Sep 23, 2022

Unregistered trackers aren't clear, so then we never register new trackers, and thus never get notified of any changes.

@ccutrer
Fix StartLevelService "hanging" if config is changed.
eb2f286 
Unregistered trackers aren't clear, so then we never register new trackers,
and thus never get notified of any changes.

Signed-off-by: Cody Cutrer <cody@cutrer.us>
@ccutrer ccutrer requested a review from a team as a code owner September 23, 2022 19:15
ccutrer added a commit to ccutrer/rspec-openhab-scripting that referenced this pull request Sep 23, 2022
@ccutrer
work around openhab-core issue
ea0fb67 
see openhab/openhab-core#3092
J-N-K
J-N-K approved these changes Sep 25, 2022
View reviewed changes
Copy link
Member

@J-N-K J-N-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks.

@J-N-K J-N-K added the bug An unexpected problem or unintended behavior of the Core label Sep 25, 2022
@J-N-K J-N-K added this to the 3.4 milestone Sep 25, 2022
@J-N-K J-N-K merged commit 065e33f into openhab:main Sep 25, 2022
@ccutrer ccutrer deleted the start-level-service branch October 4, 2022 19:35
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 12, 2023
@ccutrer @splatch
Fix StartLevelService "hanging" if config is changed. (openhab#3092)
b6bce34 
Unregistered trackers aren't clear, so then we never register new trackers,
and thus never get notified of any changes.

Signed-off-by: Cody Cutrer <cody@cutrer.us>

Signed-off-by: Cody Cutrer <cody@cutrer.us>
GitOrigin-RevId: 065e33f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J-N-K J-N-K J-N-K approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of the Core
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ccutrer @J-N-K