fix invertible unit conversions when sent via a binding #3134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cody Cutrer <cody@cutrer.us>
|
Did you check if there are other places in the code where this would be necessary? |
|
I checked with the original commit. I'm not sure how I missed this one. Checking again, ItemUIRegistryImpl.convertStateToLabelUnit is a candidate to change, but I'm not familiar with what it does. Looks like sitemaps maybe? Seems like it should; I'll push up a commit for it. The functions in QuantityTypeArithmeticGroupFunction are other possibilities, but I'm not sure if it makes any sense to support summing mireds. |
Signed-off-by: Cody Cutrer <cody@cutrer.us>
Signed-off-by: Cody Cutrer <cody@cutrer.us>
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 12, 2023
…emUIRegistry (openhab#3134) * fix invertible unit conversions when sent via a binding * do invertible unit conversion in ItemUIRegistry Signed-off-by: Cody Cutrer <cody@cutrer.us> GitOrigin-RevId: a7d912d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.