Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only call getVolume when necessary #3280

Merged
merged 1 commit into from Dec 29, 2022
Merged

Only call getVolume when necessary #3280

merged 1 commit into from Dec 29, 2022

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Dec 29, 2022

No description provided.

@jimtng
Only call getVolume when necessary
32da36f 
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
@jimtng jimtng requested a review from a team as a code owner December 29, 2022 06:32
J-N-K
J-N-K approved these changes Dec 29, 2022
View reviewed changes
Copy link
Member

@J-N-K J-N-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Although I don't feel comfortable with the lack of tests for this part of the code. I would very much welcome if better test coverage would be added to the voice bundle in the future.

@J-N-K J-N-K added this to the 4.0 milestone Dec 29, 2022
@J-N-K J-N-K added the enhancement An enhancement or new feature of the Core label Dec 29, 2022
@J-N-K J-N-K merged commit ab96a6b into openhab:main Dec 29, 2022
@jimtng jimtng deleted the getvolume branch December 29, 2022 11:26
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 12, 2023
@jimtng @splatch
[voice ]Only call getVolume when necessary (openhab#3280)
223ab68 
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
GitOrigin-RevId: ab96a6b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J-N-K J-N-K J-N-K approved these changes

Assignees
No one assigned
Labels
enhancement An enhancement or new feature of the Core
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jimtng @J-N-K