[core] Add DateTimeType method for returning Instant
#3287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/openhab-4-0-wishlist/142388/109 |
|
Thank you @jlaur ! |
jlaur
changed the title
Instant
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 12, 2023
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk> GitOrigin-RevId: 100aa6e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wish from forum post:
In relation to #2898 the plan would be to internally switch from
ZonedDateTimetoInstantwhile preserving backwards compatibility. This meansgetZonedDateTime()will stay, but it will eventually be changed to return aZonedDateTimewith the currently configured time-zone based on the internalInstant.Therefore it would only be natural to also add a method for returning the
Instantrepresentation of the current object. This does not need to wait for the additional refactoring as it will provide user value right away, but implementation will of course change when we figure out how to makeTimeZoneProvideraccessible fromDateTimeType.