Fix wrong .historicState call in .changedSince #3348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When calculating `.changedSince` the "then" state is queried via the `.historicState` method. Regardless of the `serviceId` used when calling `.changedSince` the historic state was always queried from the default persistence service. Signed-off-by: Jan N. Klug <github@klug.nrw>
J-N-K
added
bug
J-N-K
changed the title
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/oh-3-4-history-changedsince-always-returns-true/143869/25 |
|
@openhab/core-maintainers, would this qualify to be cherry-picked into 3.4.x? |
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 12, 2023
When calculating `.changedSince` the "then" state is queried via the `.historicState` method. Regardless of the `serviceId` used when calling `.changedSince` the historic state was always queried from the default persistence service. Signed-off-by: Jan N. Klug <github@klug.nrw> GitOrigin-RevId: dd89d7b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calculating
.changedSincethe "then" state is queried via the.historicStatemethod. Regardless of theserviceIdused when calling.changedSincethe historic state was always queried from the default persistence service.Signed-off-by: Jan N. Klug github@klug.nrw