Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for things with generic channels #3355

Merged
merged 4 commits into from Jun 25, 2023

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented Feb 5, 2023

Some bindings (like MQTT, HTTP and some 3rd party code) provide "generic channels", i.e. channels which can be used to provide content to a certain item-type. The channels share the code for converting to a Command or State and also code for pre-processing the raw content. Since it does not make sense to have the same code in different places, this should be handled in core.

Also necessary for openhab/openhab-addons#14345.

Signed-off-by: Jan N. Klug github@klug.nrw

@J-N-K J-N-K added the enhancement An enhancement or new feature of the Core label Feb 5, 2023
@J-N-K J-N-K requested a review from a team as a code owner February 5, 2023 11:52
@J-N-K J-N-K force-pushed the feature-genericchannels branch 2 times, most recently from 7c648fb to c13fa9c Compare May 19, 2023 07:37
@J-N-K J-N-K added rebuild Triggers the Jenkins PR build and removed rebuild Triggers the Jenkins PR build labels May 30, 2023
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thank you!
Just one small question before merging.

Signed-off-by: Jan N. Klug <github@klug.nrw>
Signed-off-by: Jan N. Klug <github@klug.nrw>
Signed-off-by: Jan N. Klug <github@klug.nrw>
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imho, the correct internal package would be

org.openhab.core.thing.internal.binding.generic.converter

instead of

org.openhab.core.thing.binding.internal.generic.converter

since the bundle name is org.openhab.core.thing.

Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K
Copy link
Member Author

J-N-K commented Jun 25, 2023

done

Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kaikreuzer kaikreuzer merged commit 78e6674 into openhab:main Jun 25, 2023
3 checks passed
@J-N-K J-N-K deleted the feature-genericchannels branch June 25, 2023 15:23
@kaikreuzer kaikreuzer added this to the 4.0 milestone Jun 25, 2023
wborn added a commit to wborn/openhab-addons that referenced this pull request Jun 26, 2023
With openhab/openhab-core#3355 the dependencies changed.

Signed-off-by: Wouter Born <github@maindrain.net>
jlaur pushed a commit to openhab/openhab-addons that referenced this pull request Jun 26, 2023
With openhab/openhab-core#3355 the dependencies changed.

Signed-off-by: Wouter Born <github@maindrain.net>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Jul 8, 2023
With openhab/openhab-core#3355 the dependencies changed.

Signed-off-by: Wouter Born <github@maindrain.net>
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 12, 2023
* Add support for generic channels

Signed-off-by: Jan N. Klug <github@klug.nrw>
GitOrigin-RevId: 78e6674
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Aug 9, 2023
With openhab/openhab-core#3355 the dependencies changed.

Signed-off-by: Wouter Born <github@maindrain.net>
Signed-off-by: Matt Myers <mmyers75@icloud.com>
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
With openhab/openhab-core#3355 the dependencies changed.

Signed-off-by: Wouter Born <github@maindrain.net>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature of the Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants