New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for things with generic channels #3355
Conversation
bdc78e1
to
e8e139a
Compare
7c648fb
to
c13fa9c
Compare
c13fa9c
to
b7c9e19
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, thank you!
Just one small question before merging.
...ava/org/openhab/core/thing/binding/generic/converter/AbstractTransformingChannelHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Jan N. Klug <github@klug.nrw>
Signed-off-by: Jan N. Klug <github@klug.nrw>
b7c9e19
to
a0bc90d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Imho, the correct internal package would be
org.openhab.core.thing.internal.binding.generic.converter
instead of
org.openhab.core.thing.binding.internal.generic.converter
since the bundle name is org.openhab.core.thing
.
Signed-off-by: Jan N. Klug <github@klug.nrw>
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
With openhab/openhab-core#3355 the dependencies changed. Signed-off-by: Wouter Born <github@maindrain.net>
With openhab/openhab-core#3355 the dependencies changed. Signed-off-by: Wouter Born <github@maindrain.net>
With openhab/openhab-core#3355 the dependencies changed. Signed-off-by: Wouter Born <github@maindrain.net>
* Add support for generic channels Signed-off-by: Jan N. Klug <github@klug.nrw> GitOrigin-RevId: 78e6674
With openhab/openhab-core#3355 the dependencies changed. Signed-off-by: Wouter Born <github@maindrain.net> Signed-off-by: Matt Myers <mmyers75@icloud.com>
With openhab/openhab-core#3355 the dependencies changed. Signed-off-by: Wouter Born <github@maindrain.net> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Some bindings (like MQTT, HTTP and some 3rd party code) provide "generic channels", i.e. channels which can be used to provide content to a certain item-type. The channels share the code for converting to a
Command
orState
and also code for pre-processing the raw content. Since it does not make sense to have the same code in different places, this should be handled in core.Also necessary for openhab/openhab-addons#14345.
Signed-off-by: Jan N. Klug github@klug.nrw