Extend item syntax for category/icon

[lolodomo]

The icon value can now contain until 3 segments separated by a semi-column.
First segment is the icon source. Example: oh, if, iconify, material, f7, ...
Second segment is the icon set. Example: classic
Third segment is the icon name (and can contain hyphen). Example: temperature

In case only two segments are provided, the first segment is the icon source and the second the icon name. "classic" icon set is assumed.
In case only one segment is provided, the icon source is assumed to be the openHAB server and its classic icon set and the value is then the icon name.

Ability to use a string containing anything has been removed.

Related to #3052

Signed-off-by: Laurent Garnier lg.hc@free.fr

[lolodomo]

With the following items definition

Number:Temperature CurrentTemp2 "Current Temp [%.1f °C]" <temperature>
Number CurrentHumidity2 "Humidity [%.0f %%]" <classic:humidity>
Number CurrentPressure2 "Pressure [%.0f hPa]" <oh:classic:pressure>
String CurrentPressureTrend2 "Pressure Trend [%s]" <material::arrow_drop_down>
Number:Temperature SetpointTemp2 "Setpoint Temp [%.1f °C]" <iconify:wi:day-sunny-overcast> [ "Setpoint", "Temperature" ]
Number:Temperature SetpointTemp3 "Setpoint Temp [%.1f °C]" <if:wi:day-thunderstorm> [ "Setpoint", "Temperature" ]
String TestString2 "Test string [%s]" <material::favorite>

and this sitemap

sitemap test5 label="Tests"
{
        Frame label="Icon ref in items" {
                Default item=CurrentTemp2
                Default item=CurrentHumidity2
                Default item=CurrentPressure2
                Default item=CurrentPressureTrend2
                Default item=SetpointTemp2 iconcolor=["orange"]
                Default item=SetpointTemp3
                Default item=TestString2 iconcolor=["red"]
        }
}

here is the result in Basic UI:

[lolodomo]

It seems the build succeeded but with the now so famous final "Finished: UNSTABLE".

[lolodomo]

I finally changed the expectation when the icon value contains only 2 segments to be more compliant with Main UI syntax.
With the following items definition

Number:Temperature CurrentTemp2 "Current Temp [%.1f °C]" <temperature>
Number CurrentHumidity2 "Humidity [%.0f %%]" <oh:humidity>
Number CurrentPressure2 "Pressure [%.0f hPa]" <oh:classic:pressure>
String CurrentPressureTrend2 "Pressure Trend [%s]" <material:arrow_drop_down>
Number:Temperature SetpointTemp2 "Setpoint Temp [%.1f °C]" <iconify:wi:day-sunny-overcast> [ "Setpoint", "Temperature" ]
Number:Temperature SetpointTemp3 "Setpoint Temp [%.1f °C]" <if:wi:day-thunderstorm> [ "Setpoint", "Temperature" ]
String TestString2 "Test string [%s]" <material:favorite>

and this sitemap

sitemap test5 label="Tests"
{
        Frame label="Icon ref in items" {
                Default item=CurrentTemp2
                Default item=CurrentHumidity2
                Default item=CurrentPressure2
                Default item=CurrentPressureTrend2
                Default item=SetpointTemp2 iconcolor=["orange"]
                Default item=SetpointTemp3
                Default item=TestString2 iconcolor=["red"]
        }
}

here is the result in an updated version of Basic UI:

[lolodomo]

Note that it is a breaking change as quotes are no more accepted inside the <>. I created an update warning for that.

[mherwege]

@lolodomo I assume this will not impact the definition of icons in a sitemap file using the icon="iconname" syntax? Are segmented icon definitions in sitemaps supported as well?

[lolodomo]

@lolodomo I assume this will not impact the definition of icons in a sitemap file using the icon="iconname" syntax? Are segmented icon definitions in sitemaps supported as well?

Yes, it was changed in #3378.

[mherwege]

@lolodomo @J-N-K I created openhab/openhab-webui#1843 that includes fixes for this, tested with the examples provided.

[openhab-bot]

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/openhab4-m1-earlybird/145193/25