Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception in TransformationHelper #3627

Merged
merged 1 commit into from May 25, 2023

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented May 24, 2023

Fixes openhab/openhab-webui#1867

Runtime exceptions thrown by transformation services propagated from the TransformationHelper to the EnrichtedItemDTOMapper to the ItemResource. In general transformation services should throw TransformationException and this should be fixed there but in this case safe-guarding the TransformationHelper makes sense because of the severity of issues created by fault add-ons.

Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K J-N-K added the bug An unexpected problem or unintended behavior of the Core label May 24, 2023
@J-N-K J-N-K requested a review from a team as a code owner May 24, 2023 16:12
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kaikreuzer kaikreuzer merged commit 8e81beb into openhab:main May 25, 2023
3 checks passed
@kaikreuzer kaikreuzer added this to the 4.0 milestone May 25, 2023
@J-N-K J-N-K deleted the bug-transformexception branch May 25, 2023 06:39
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 12, 2023
Signed-off-by: Jan N. Klug <github@klug.nrw>
GitOrigin-RevId: 8e81beb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of the Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MainUI] Items overview page does not load when script transformation throws error
2 participants