[persistence] Don't require relative, inverted and unit fields for filter configuration over REST
#3681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tive, inverted if those are null This allows MainUI to send requests without ensuring that these fields are set. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
florian-h05
added a commit
to florian-h05/openhab-webui
that referenced
this pull request
Jul 3, 2023
Depends on openhab/openhab-core#3681. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
florian-h05
changed the title
relative, inverted and unit fields in REST requestrelative, inverted and unit fields for filter configuration over REST
|
I'm not sure this is the best way. IMO it would better to make the constructors accept a null value and set the default in the filter class. That makes it much clearer what the default is and also works in other places. WDYT? |
|
Isn't it better to make this particular DTO mapper non-static? It seems to be that |
I will try that. |
|
I am currently on holiday in France, so I won’t be able to work on this soon. Let’s postpone it for openHAB 4.1, since the feature freeze will start on Sunday. |
florian-h05
added a commit
to florian-h05/openhab-webui
that referenced
this pull request
Jul 14, 2023
Depends on openhab/openhab-core#3681. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
florian-h05
added a commit
to florian-h05/openhab-webui
that referenced
this pull request
Jul 18, 2023
Depends on openhab/openhab-core#3681. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
florian-h05
added a commit
to florian-h05/openhab-core
that referenced
this pull request
Jul 20, 2023
Setting up a treshold filter with the UI, it did not work because the unit field was blank. I got an NPE from PersistenceTresholdFilter, and the PersistenceIncludeFilter would also throw a NPE in that case. For PersistenceTimeFilter, defaulting to "s" is just cosmetic. Picks-up PR openhab#3681 and should be merged for the 4.0 release, because the UI does not prevent the unit field from being null. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
J-N-K
pushed a commit
that referenced
this pull request
Jul 20, 2023
Setting up a treshold filter with the UI, it did not work because the unit field was blank. I got an NPE from PersistenceTresholdFilter, and the PersistenceIncludeFilter would also throw a NPE in that case. For PersistenceTimeFilter, defaulting to "s" is just cosmetic. Picks-up PR #3681 and should be merged for the 4.0 release, because the UI does not prevent the unit field from being null. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While creating the persistence edit page, I noticed that PUT
/rest/persistence/{serviceId}requests fail when the boolean propertiesinvertedandrelativeof some persistence filters are not set. First, I ensured that they are set when the UI saves the persistence configuration, however IMO this should be in core.Setting up a treshold filter with the UI, it did not work because the
unitfield was blank (I got an NPE fromPersistenceTresholdFilter, and thePersistenceIncludeFilterwould also throw a NPE.This PR sets reasonable defaults for those fields that are required by core, but not neccassarily set by the user.
/cc @J-N-K