Align system-channel-types for electricity #3707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are only used by one binding at the moment and it's very inconsistent to have power, voltage and current with the "electric" prefix and energy with "electrical". Signed-off-by: Jan N. Klug <github@klug.nrw>
clinique
approved these changes
Jul 17, 2023
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/openhab-4-0-milestone-discussion/145133/563 |
jlaur
reviewed
Jul 17, 2023
| @@ -391,7 +391,7 @@ public class DefaultSystemChannelTypeProvider implements ChannelTypeProvider { | |||
| * Electrical-energy: system wide {@link ChannelType} which shows the electrical energy | |||
| */ | |||
| public static final ChannelType SYSTEM_ELECTRICAL_ENERGY = ChannelTypeBuilder | |||
| .state(SYSTEM_CHANNEL_TYPE_UID_ELECTRICAL_ENERGY, "Electrical Energy", "Number:Energy") | |||
| .state(SYSTEM_CHANNEL_TYPE_UID_ELECTRIC_ENERGY, "Electrical Energy", "Number:Energy") | |||
There was a problem hiding this comment.
Should the label also be updated accordingly?
Suggested change
| .state(SYSTEM_CHANNEL_TYPE_UID_ELECTRIC_ENERGY, "Electrical Energy", "Number:Energy") | |
| .state(SYSTEM_CHANNEL_TYPE_UID_ELECTRIC_ENERGY, "Electric Energy", "Number:Energy") |
and description below:
Signed-off-by: Jan N. Klug <github@klug.nrw>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are only used by one binding at the moment and it's very inconsistent to have power, voltage and current with the "electric" prefix and energy with "electrical".