Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rule startlevel trigger executes during initialization #3717

Merged
merged 2 commits into from Jul 21, 2023
Merged

Fix rule startlevel trigger executes during initialization #3717

merged 2 commits into from Jul 21, 2023

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented Jul 20, 2023

Fixes #3713

@J-N-K
Fix rule startlevel trigger executes during initialization
f22c90d 
Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K J-N-K added the bug An unexpected problem or unintended behavior of the Core label Jul 20, 2023
@J-N-K J-N-K requested a review from a team as a code owner July 20, 2023 15:17
kaikreuzer
kaikreuzer reviewed Jul 20, 2023
View reviewed changes
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - could you please have a look at the failing test?

@J-N-K
fix itests
750bdb6 
Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K
Copy link
Member Author

J-N-K commented Jul 21, 2023

done

kaikreuzer
kaikreuzer approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kaikreuzer kaikreuzer merged commit b8ae55c into openhab:main Jul 21, 2023
3 checks passed
@kaikreuzer kaikreuzer added this to the 4.0 milestone Jul 21, 2023
@J-N-K J-N-K deleted the fix-ruletriggersduringinit branch July 21, 2023 12:28
@lolodomo lolodomo mentioned this pull request Jul 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaikreuzer kaikreuzer kaikreuzer approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of the Core
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

System runlevel triggered rules trigger before done being saved
2 participants
@J-N-K @kaikreuzer