Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MQTT client crashes when subscriber throws exception #3719

Merged
merged 1 commit into from Jul 21, 2023
Merged

Fix MQTT client crashes when subscriber throws exception #3719

merged 1 commit into from Jul 21, 2023

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented Jul 21, 2023

@J-N-K
Fix MQTT crashes when subscriber throws exception
21ac7de 
Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K J-N-K added the bug An unexpected problem or unintended behavior of the Core label Jul 21, 2023
@J-N-K J-N-K requested a review from a team as a code owner July 21, 2023 14:31
@J-N-K
Copy link
Member Author

J-N-K commented Jul 21, 2023

@kaikreuzer Can you merge this one, too? It's super-low risk because it just adds a try-catch-block for RuntimeException.

kaikreuzer
kaikreuzer approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

@kaikreuzer kaikreuzer merged commit 573c94b into openhab:main Jul 21, 2023
3 checks passed
@kaikreuzer kaikreuzer added this to the 4.0 milestone Jul 21, 2023
@J-N-K J-N-K deleted the fix-mqtt branch July 21, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaikreuzer kaikreuzer kaikreuzer approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of the Core
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

[mqtt] MQTT thing stops working after receiving "null" message
2 participants
@J-N-K @kaikreuzer