[Audio] Add piped audio stream and fix raw PCM streams format #3960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiviMAD
force-pushed
the
audio/piped_audio_fix_pcm
branch
2 times, most recently
from
8b667c4
to
33b9703
Compare
Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
GiviMAD
force-pushed
the
audio/piped_audio_fix_pcm
branch
from
df76007
to
190fd7a
Compare
|
I have rebased the PR to remove a comment change that has been already fixed at main and was not related. |
Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
kaikreuzer
requested changes
Jan 6, 2024
bundles/org.openhab.core.audio/src/main/java/org/openhab/core/audio/AudioFormat.java
Show resolved
Hide resolved
bundles/org.openhab.core.audio/src/main/java/org/openhab/core/audio/PipedAudioStream.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.core.audio/src/main/java/org/openhab/core/audio/PipedAudioStream.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.core.audio/src/main/java/org/openhab/core/audio/PipedAudioStream.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.core.audio/src/main/java/org/openhab/core/audio/PipedAudioStream.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.core.audio/src/main/java/org/openhab/core/audio/PipedAudioStream.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.core.audio/src/main/java/org/openhab/core/audio/PipedAudioStream.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.core.audio/src/main/java/org/openhab/core/audio/PipedAudioStream.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.core.audio/src/main/java/org/openhab/core/audio/PipedAudioStream.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.core.audio/src/main/java/org/openhab/core/audio/PipedAudioStream.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
|
I have added a |
cipianpascu
pushed a commit
to cipianpascu/openhab-core
that referenced
this pull request
Jan 17, 2024
…b#3960) * [Audio] Add piped audio stream and fix pcm format usage Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com> Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I want to add a new audio stream implementation to send infinite audio streams and multiplex its data to the different consumers. At the same time I discovered I had committed an error across all the source implementations which is create its format using the CONTAINER_WAV while those streams are raw pcm streams and should use the CONTAINER_NONE instead (I don't think it needs to be treated as a bug and back-ported because I was consistent with the error and it has no effect on the 4.1.x code).
I'm going to open a PR in the add-ons to adapt them to these changes.
The use cases for the new stream type are: