Simplify Map operations using computeIfAbsent
#4020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J-N-K
reviewed
Jan 6, 2024
| objects = new HashMap<>(); | ||
| objectCache.put(scriptIdentifier, objects); | ||
| } | ||
| Map<String, Object> objects = objectCache.computeIfAbsent(scriptIdentifier, k -> new HashMap<>()); |
There was a problem hiding this comment.
The problem is that this always creates a warning in the compiler because the EEA can't properly model "return value is non-null if second parameter is non-null" and assumes the return value is nullable.
Unfortunately the ECJ guys don't see the problem or the need to improve that.
There was a problem hiding this comment.
We had the same situation recently here: openhab/openhab-addons#15828 (comment). Maybe a similar work-around could be used here as well.
wborn
force-pushed
the
use-computeIfAbsent
branch
from
2ad331c
to
4a52de9
Compare
If the specified key is not already associated with a value (or is mapped to null), the given mapping function computes the value. Signed-off-by: Wouter Born <github@maindrain.net>
wborn
force-pushed
the
use-computeIfAbsent
branch
from
4a52de9
to
af9d3f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the specified key is not already associated with a value (or is mapped to null), the given mapping function computes the value.