Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some more code cleanup #4021

Merged
merged 1 commit into from Feb 4, 2024
Merged

Some more code cleanup #4021

merged 1 commit into from Feb 4, 2024

Conversation

wborn
Copy link
Member

@wborn wborn commented Jan 5, 2024

This cleanup includes:

  • Use enhanced for loops
  • Use text blocks
  • Use Objects.equals
  • Fix some typos
  • Remove redundant variable initialization
  • Remove redundant null checks with instanceof
  • Remove redundant thrown Exceptions
  • Remove redundant empty String concatenation

This cleanup includes:

* Use enhanced for loops
* Use text blocks
* Use Objects.equals
* Fix some typos
* Remove redundant variable initialization
* Remove redundant null checks with instanceof
* Remove redundant thrown Exceptions
* Remove redundant empty String concatenation

Signed-off-by: Wouter Born <github@maindrain.net>
@wborn wborn requested a review from a team as a code owner January 5, 2024 22:45
Copy link
Member

@J-N-K J-N-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

Copy link
Member

@J-N-K J-N-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@J-N-K J-N-K merged commit 85056d9 into openhab:main Feb 4, 2024
3 checks passed
@J-N-K J-N-K added the enhancement An enhancement or new feature of the Core label Feb 4, 2024
@J-N-K J-N-K added this to the 4.2 milestone Feb 4, 2024
@wborn wborn deleted the more-code-cleanup branch February 4, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature of the Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants